[cmd/mdatagen] remove validation from k8s/container and k8s/pod #23794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI on main is broken after open-telemetry#23783 and open-telemetry#23441 got merged, because k8s/container and k8s/pod: - don't have the parent field - some metrics are missing units.
dmitryax
approved these changes
Jun 27, 2023
|
The issue is resolved in #23795 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
CI on main is broken after #23783 and #23441 got merged, because
k8s/containers andk8s/podsmetadata.yaml:This PR temporarily removes validation for
k8s/containerandk8s/pod(and add a//TODO) until the missing fields are added.Note: this was not caught on the CI for #23783 because #23441 was not included in the branch.
Link to tracking Issue:
#23793