Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mdatgen] add redhat distro hint #23603

Merged
merged 2 commits into from
Jun 21, 2023
Merged

[mdatgen] add redhat distro hint #23603

merged 2 commits into from
Jun 21, 2023

Conversation

frzifus
Copy link
Member

@frzifus frzifus commented Jun 21, 2023 •
edited
Loading

Description:

Adds references to the OpenShift OpenTelemetry distro provided by redhat.

Link to tracking Issue:

Testing:

Documentation:

@frzifus
[mdatagen] add redhat distro hint
a603e6e 
Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
@frzifus frzifus requested a review from a team June 21, 2023 09:45
@frzifus frzifus requested a review from a team June 21, 2023 09:45
@frzifus frzifus added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jun 21, 2023
@frzifus
Copy link
Member Author

frzifus commented Jun 21, 2023

hm.. I assume this k8s test is just flaky.

mx-psi
mx-psi approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can you add a description to the PR?

@mx-psi
Copy link
Member

mx-psi commented Jun 21, 2023

Looks like you also need to make generate

@frzifus
[mdatagen] regenerate
7b95a59 
Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
@frzifus
Copy link
Member Author

frzifus commented Jun 21, 2023

done 👍

@codeboten codeboten merged commit 4b0fe71 into open-telemetry:main Jun 21, 2023
@github-actions github-actions bot added this to the next release milestone Jun 21, 2023
@frzifus frzifus deleted the add_redhat_distro_hint branch June 21, 2023 15:58
fchikwekwe pushed a commit to fchikwekwe/opentelemetry-collector-contrib that referenced this pull request Jun 23, 2023
@frzifus @fchikwekwe
[mdatgen] add redhat distro hint (open-telemetry#23603)
211dc0d 
Adds references to the OpenShift OpenTelemetry distro provided by
redhat.

---------

Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
Caleb-Hurshman pushed a commit to observIQ/opentelemetry-collector-contrib that referenced this pull request Jul 6, 2023
@frzifus @Caleb-Hurshman
[mdatgen] add redhat distro hint (open-telemetry#23603)
f13cc22 
Adds references to the OpenShift OpenTelemetry distro provided by
redhat.

---------

Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi approved these changes

@codeboten codeboten codeboten approved these changes

@MovieStoreGuy MovieStoreGuy Awaiting requested review from MovieStoreGuy MovieStoreGuy is a code owner

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel andrzej-stencel is a code owner

@jpkrohling jpkrohling Awaiting requested review from jpkrohling jpkrohling is a code owner

@kovrus kovrus Awaiting requested review from kovrus

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@fatsheep9146 fatsheep9146 Awaiting requested review from fatsheep9146 fatsheep9146 is a code owner

@TylerHelmuth TylerHelmuth Awaiting requested review from TylerHelmuth TylerHelmuth is a code owner

Assignees

@Aneurysm9 Aneurysm9

Labels
cmd/mdatagen mdatagen command exporter/jaeger exporter/prometheus extension/basicauth extension/bearertokenauth extension/healthcheck Health Check Extension extension/jaegerremotesampling extension/oauth2clientauth extension/pprof processor/attributes Attributes processor processor/filter Filter processor processor/k8sattributes k8s Attributes processor processor/resource Resource processor processor/resourcedetection Resource detection processor processor/routing Routing processor processor/span receiver/jaeger receiver/opencensus receiver/zipkin Zipkin receiver Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v0.81.0
Development

Successfully merging this pull request may close these issues.
4 participants
@frzifus @mx-psi @codeboten @Aneurysm9