Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing unit in metadata.yaml #23449

Closed
wants to merge 12 commits into from
Closed

Add missing unit in metadata.yaml #23449

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
097a7d6
Add missing unit in metadata.yaml
mackjmr Jun 19, 2023
2e09f91
Update receiver/redisreceiver/metadata.yaml
mackjmr Jun 19, 2023
2ff3137
Update receiver/redisreceiver/metadata.yaml
mackjmr Jun 19, 2023
2687cf8
Update receiver/redisreceiver/metadata.yaml
mackjmr Jun 19, 2023
dc5836a
Update receiver/redisreceiver/metadata.yaml
mackjmr Jun 19, 2023
d1f6034
Remove By and run make generate
mackjmr Jun 19, 2023
1415848
remove ratio
mackjmr Jun 19, 2023
85bd0af
run golden.WriteMetrics
mackjmr Jun 19, 2023
2c1d741
add default unit 1
mackjmr Jun 19, 2023
f4249b8
golden.ReadMetrics for all tests
mackjmr Jun 19, 2023
fca3687
remove calls to golden.WriteMetrics
mackjmr Jun 19, 2023
4e9e9d9
run golden.WriteMetrics for all 3 receivers
mackjmr Jun 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove calls to golden.WriteMetrics
  • Loading branch information
@mackjmr
mackjmr committed Jun 19, 2023
commit fca368741e6eaf03667e5998e916d52cc4b91b7f
5 changes: 0 additions & 5 deletions receiver/postgresqlreceiver/scraper_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ func TestScraper(t *testing.T) {
require.NoError(t, err)

expectedFile := filepath.Join("testdata", "scraper", "otel", "expected.yaml")
golden.WriteMetrics(t, expectedFile, actualMetrics)
expectedMetrics, err := golden.ReadMetrics(expectedFile)
require.NoError(t, err)

Expand All @@ -62,7 +61,6 @@ func TestScraperNoDatabaseSingle(t *testing.T) {
require.NoError(t, err)

expectedFile := filepath.Join("testdata", "scraper", "otel", "expected.yaml")
golden.WriteMetrics(t, expectedFile, actualMetrics)
expectedMetrics, err := golden.ReadMetrics(expectedFile)
require.NoError(t, err)

Expand All @@ -81,7 +79,6 @@ func TestScraperNoDatabaseMultiple(t *testing.T) {
require.NoError(t, err)

expectedFile := filepath.Join("testdata", "scraper", "multiple", "expected.yaml")
golden.WriteMetrics(t, expectedFile, actualMetrics)
expectedMetrics, err := golden.ReadMetrics(expectedFile)
require.NoError(t, err)

Expand All @@ -100,7 +97,6 @@ func TestScraperWithResourceAttributeFeatureGate(t *testing.T) {
require.NoError(t, err)

expectedFile := filepath.Join("testdata", "scraper", "multiple", "expected_with_resource.yaml")
golden.WriteMetrics(t, expectedFile, actualMetrics)
expectedMetrics, err := golden.ReadMetrics(expectedFile)
require.NoError(t, err)

Expand All @@ -119,7 +115,6 @@ func TestScraperWithResourceAttributeFeatureGateSingle(t *testing.T) {
require.NoError(t, err)

expectedFile := filepath.Join("testdata", "scraper", "otel", "expected_with_resource.yaml")
golden.WriteMetrics(t, expectedFile, actualMetrics)
expectedMetrics, err := golden.ReadMetrics(expectedFile)
require.NoError(t, err)

Expand Down