Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] update linter version #22983

Merged
merged 4 commits into from
Jun 1, 2023
Merged

[chore] update linter version #22983

merged 4 commits into from
Jun 1, 2023

Conversation

codeboten
Copy link
Contributor

Fixes #20424

[chore] update linter version
a20c75f 
Fixes open-telemetry#20424

Signed-off-by: Alex Boten <aboten@lightstep.com>
@codeboten codeboten requested review from a team and songy23 May 31, 2023 20:05
one more unused param
1a97481 
Signed-off-by: Alex Boten <aboten@lightstep.com>
@codeboten codeboten requested a review from dashpole as a code owner May 31, 2023 20:48
@github-actions github-actions bot added the receiver/nsxt NSXT Receiver label May 31, 2023
@github-actions github-actions bot requested a review from schmikei May 31, 2023 20:48
more unused params, remove copylocks lint error
54fb0f8 
Signed-off-by: Alex Boten <aboten@lightstep.com>
a few more unused params
e56a09a 
Signed-off-by: Alex Boten <aboten@lightstep.com>
@codeboten codeboten requested a review from Aneurysm9 as a code owner June 1, 2023 17:09
@codeboten
Copy link
Contributor Author

codeboten commented Jun 1, 2023 •
edited
Loading

Likely will be blocked by #23001

Apparently just in my local dev env

@codeboten codeboten merged commit 44c8882 into open-telemetry:main Jun 1, 2023
@codeboten codeboten deleted the codeboten/bump-linter-version branch June 1, 2023 18:23
@github-actions github-actions bot added this to the next release milestone Jun 1, 2023
Caleb-Hurshman pushed a commit to observIQ/opentelemetry-collector-contrib that referenced this pull request Jul 6, 2023
@Caleb-Hurshman
[chore] update linter version (open-telemetry#22983)
d7c766b 
Fixes open-telemetry#20424

---------

Signed-off-by: Alex Boten <aboten@lightstep.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobert-1 crobert-1 crobert-1 approved these changes

@songy23 songy23 songy23 approved these changes

@dmitryax dmitryax dmitryax approved these changes

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@schmikei schmikei Awaiting requested review from schmikei

@atoulme atoulme Awaiting requested review from atoulme atoulme is a code owner

@djaglowski djaglowski Awaiting requested review from djaglowski

@jpkrohling jpkrohling Awaiting requested review from jpkrohling

@MovieStoreGuy MovieStoreGuy Awaiting requested review from MovieStoreGuy MovieStoreGuy is a code owner

@altuner altuner Awaiting requested review from altuner

@boostchicken boostchicken Awaiting requested review from boostchicken

@gouthamve gouthamve Awaiting requested review from gouthamve

@pjanotti pjanotti Awaiting requested review from pjanotti

@pmcollins pmcollins Awaiting requested review from pmcollins

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

Assignees

@TylerHelmuth TylerHelmuth

Labels
internal/tools receiver/awscontainerinsight receiver/azuremonitor receiver/carbon receiver/datadog receiver/file receiver/filestats receiver/hostmetrics receiver/kubeletstats receiver/nsxt NSXT Receiver receiver/oracledb
Projects
None yet
Milestone
v0.79.0
Development

Successfully merging this pull request may close these issues.

update github.com/golangci/golangci-lint from 1.51.1 to 1.52.2 causes issues
5 participants
@codeboten @dmitryax @songy23 @crobert-1 @TylerHelmuth