[receiver/hostmetrics] Change method to get parent Pid in function parentPid #22920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
reviewed
Jun 1, 2023
receiver/hostmetricsreceiver/internal/scraper/processscraper/process.go
Outdated
Show resolved
Hide resolved
dmitryax
approved these changes
Jun 2, 2023
dmitryax
added
the
ready to merge
TylerHelmuth
approved these changes
Jun 2, 2023
|
@JadziaMataj please add a changelog entry for this bug fix |
TylerHelmuth
removed
the
ready to merge
@TylerHelmuth sorry for delay. Changelog is added. |
TylerHelmuth
added
the
ready to merge
TylerHelmuth
reviewed
Jun 6, 2023
Caleb-Hurshman
pushed a commit
to observIQ/opentelemetry-collector-contrib
that referenced
this pull request
Jul 6, 2023
…rentPid (open-telemetry#22920) * change method to get parent Pid in function parentPid * refactor - remove if * fix after review - remove assignment * fix tests * add chlog file * update chlog file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Change method to get parent Pid in function parentPid.
Fixing the bug with reading parent pid for Windows processes.
Link to tracking Issue: 14679
Testing: Testing was performed manually on Windows 10. The error "error reading parent pid for process" has not occurred in the logs.
Documentation: is not needed