-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pkg/ottl] Add string access for span kind #21773
[pkg/ottl] Add string access for span kind #21773
Conversation
/cc @dmitryax bc I had to add a new function to |
cmiiw OTTL user (like tail sampling processor) will benefit from all those new OTTL feature right? I'm trying to be understand that what kind of change will benefit OTTL user component, and what will not :/ Edit: OK so the core idea is to secure that I am writing the correct code for tail sampling processor, allowing it to get the latest update of OTTL (everytime, in the future) :) |
@jiekun A change like this would be immediately useable by any component that uses OTTL's standard contexts (in Contrib all the components using OTTL use the standard contexts) so the tailsamplingprocessor would get it. That is in contrast to new functions which a component needs to opt into. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
53fad0f
to
62c9c72
Compare
Description:
Adds a new access available to ottlspan and ottlspanevent that allows getting and setting the span kind using a string. This accessor is necessary to facilitate #21054, as the current
internal/filterspan
logic allows filtering span kind based on the string interpretation.Testing:
Added new tests
Documentation:
Updated ottlspan README with new accessor.