Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pkg/stanza/fileconsumer] Refactor makeReaders into makeReader #21734

Merged
merged 2 commits into from
May 11, 2023
Merged

[pkg/stanza/fileconsumer] Refactor makeReaders into makeReader #21734

merged 2 commits into from
May 11, 2023

Conversation

VihasMakwana
Copy link
Contributor

Description: Just some code refactoring and to separate these changes from #19448

Link to tracking Issue:

Testing:

Documentation:

@VihasMakwana VihasMakwana requested a review from a team May 10, 2023 13:37
@VihasMakwana VihasMakwana requested a review from djaglowski as a code owner May 10, 2023 13:37
@djaglowski djaglowski changed the title Refactor changes to have better readability. [pkg/stanza/fileconsumer] Refactor changes to have better readability. May 10, 2023
djaglowski
djaglowski reviewed May 10, 2023
View reviewed changes
Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can accept a worker pool unless it is behind a featuregate. Can you please remove the worker related changes from this PR?

@VihasMakwana
Copy link
Contributor Author

Okay sounds fair

@VihasMakwana VihasMakwana force-pushed the refactor-filelog-receiver branch 3 times, most recently from 89d632e to 227afb8 Compare May 11, 2023 06:24
@VihasMakwana VihasMakwana force-pushed the refactor-filelog-receiver branch from 227afb8 to 28eb682 Compare May 11, 2023 06:25
@VihasMakwana VihasMakwana requested a review from djaglowski May 11, 2023 06:26
djaglowski
djaglowski reviewed May 11, 2023
View reviewed changes
pkg/stanza/fileconsumer/file.go Outdated Show resolved Hide resolved
pkg/stanza/fileconsumer/file.go Outdated Show resolved Hide resolved
pkg/stanza/fileconsumer/file.go Outdated Show resolved Hide resolved
pkg/stanza/fileconsumer/file.go Outdated Show resolved Hide resolved
@VihasMakwana VihasMakwana force-pushed the refactor-filelog-receiver branch from 89628c6 to 1a6f022 Compare May 11, 2023 16:18
@djaglowski djaglowski added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 11, 2023
djaglowski
djaglowski approved these changes May 11, 2023
View reviewed changes
Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @VihasMakwana

@djaglowski djaglowski merged commit b381ffd into open-telemetry:main May 11, 2023
@djaglowski djaglowski changed the title [pkg/stanza/fileconsumer] Refactor changes to have better readability. [pkg/stanza/fileconsumer] Refactor makeReaders into makeReader May 11, 2023
@github-actions github-actions bot added this to the next release milestone May 11, 2023
@crobert-1 crobert-1 mentioned this pull request May 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djaglowski djaglowski djaglowski approved these changes

Assignees
No one assigned
Labels
pkg/stanza Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v0.78.0
Development

Successfully merging this pull request may close these issues.
2 participants
@VihasMakwana @djaglowski