[exporter/splunkhec] Fix logic tracking partial errors data #21720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
approved these changes
May 10, 2023
dmitryax
force-pushed
the
hec-exporter-remove-dead-code-path
branch
from
af18e41
to
ac19c18
Compare
dmitryax
changed the title
dmitryax
force-pushed
the
hec-exporter-remove-dead-code-path
branch
2 times, most recently
from
50d36df
to
197c530
Compare
dmitryax
changed the title
dmitryax
force-pushed
the
hec-exporter-remove-dead-code-path
branch
from
197c530
to
a75f23b
Compare
The counters tracking the sent data did not capture the state when the buffer rejected overflown data. The issue leads to incorrect data in the partial error returned by the exporter.
dmitryax
force-pushed
the
hec-exporter-remove-dead-code-path
branch
from
a75f23b
to
b1b5b66
Compare
|
Thanks for the fix :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The counters tracking the sent data did not capture the state when the buffer rejected overflown data. The issue leads to incorrect data in the partial error returned by the exporter.