Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] use status type in oracledb receiver #21284

Merged
merged 1 commit into from
May 11, 2023
Merged

[chore] use status type in oracledb receiver #21284

merged 1 commit into from
May 11, 2023

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented May 1, 2023

No description provided.

@atoulme atoulme requested a review from a team May 1, 2023 08:03
@atoulme atoulme requested a review from dmitryax as a code owner May 1, 2023 08:03
@github-actions github-actions bot requested a review from crobert-1 May 1, 2023 08:04
@dmitryax
Copy link
Member

dmitryax commented May 1, 2023

Let's hold off until the #21272 discussion is resolved

@atoulme atoulme force-pushed the use_status_type_in_oracledbreceiver branch from c21ff0b to 1cf21d3 Compare May 1, 2023 17:55
@atoulme atoulme added the on hold This is blocked by another PR/issue label May 1, 2023
@atoulme atoulme force-pushed the use_status_type_in_oracledbreceiver branch from 1cf21d3 to 2bd90df Compare May 11, 2023 04:07
@atoulme atoulme removed the on hold This is blocked by another PR/issue label May 11, 2023
crobert-1
crobert-1 approved these changes May 11, 2023
View reviewed changes
Copy link
Member

@crobert-1 crobert-1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like in discussion this is overall agreed to be the way to go, so it looks good to me as long as #21272 is approved.

@dmitryax dmitryax merged commit b00fac6 into open-telemetry:main May 11, 2023
@github-actions github-actions bot added this to the next release milestone May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobert-1 crobert-1 crobert-1 approved these changes

@dmitryax dmitryax dmitryax approved these changes

Assignees

@evan-bradley evan-bradley

Labels
receiver/oracledb
Projects
None yet
Milestone
v0.78.0
Development

Successfully merging this pull request may close these issues.
4 participants
@atoulme @dmitryax @crobert-1 @evan-bradley