-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] add metadata status checks on the distribution #21275
[chore] add metadata status checks on the distribution #21275
Conversation
This fails because are detecting a number of components are not in the test suite when they should be. |
16e4e36
to
908962a
Compare
aea863b
to
7a80573
Compare
c38054f
to
06f31ca
Compare
4fa6669
to
ac6d2dc
Compare
Maybe it's easier to have an allowlist for components where we will ignore the test failures and merge the PR now? That way we avoid introducing errors on components that are currently passing |
It's really close, just need a tidy |
6ae39b5
to
5f15c40
Compare
Seems like it's still failing |
More components have metadata, so this test now detects more components missing from otelcontribcol:
I'll add them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some conflicts to resolve
f224090
to
df9feb4
Compare
…y#21275) Add a test checking that the status metadata of a component matches their presence in the otelcontribcol test suite.
Add a test checking that the status metadata of a component matches their presence in the otelcontribcol test suite.