[sumologicexporter] Enable metrics pipeline #2117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
January 18, 2021 08:37
…tring Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
sumo-drosiek
force-pushed
the
drosiek-sumo-metrics
branch
from
680ebed
to
a52081d
Compare
Codecov Report
@@ Coverage Diff @@
## main #2117 +/- ##
==========================================
- Coverage 90.39% 90.32% -0.08%
==========================================
Files 394 394
Lines 19347 19475 +128
==========================================
+ Hits 17489 17590 +101
- Misses 1397 1419 +22
- Partials 461 466 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
dyladan
referenced
this pull request
in dynatrace-oss-contrib/opentelemetry-collector-contrib
Jan 29, 2021
|
@sumo-drosiek was this reviewed by someone that is in the owners for sumologic exporter? |
cc: @pmalek-sumo |
pmalek-sumo
approved these changes
Feb 1, 2021
pmm-sumo
approved these changes
Feb 1, 2021
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
@bogdandrutu Could we merge this PR? |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
bogdandrutu
approved these changes
Feb 20, 2021
pmatyjasek-sumo
referenced
this pull request
in pmatyjasek-sumo/opentelemetry-collector-contrib
Apr 28, 2021
* [sumologicexporter] Rename logs related buffer names to include log string Signed-off-by: Dominik Rosiek <drosiek@sumologic.com> * [sumologicexporter] Add metrics support to sender Signed-off-by: Dominik Rosiek <drosiek@sumologic.com> * [sumologicexporter] Initialise prometheusFormatter in exporter * [sumologicexporter] Use prometheusFormatter in sendMetrics * [sumologicexporter] Add support for PrometheusFormat in sender * [sumologicexporter] Add tests for sendMetrics and fix sender Signed-off-by: Dominik Rosiek <drosiek@sumologic.com> * [sumologicexporter] Add and enable metrics for exporter Signed-off-by: Dominik Rosiek <drosiek@sumologic.com> * [sumologicexporter] Use consts for sender Signed-off-by: Dominik Rosiek <drosiek@sumologic.com> * [sumologicexporter] Skip some metrics tests due to time factor * [sumologicexporter] Set prometheus as default metrics format Signed-off-by: Dominik Rosiek <drosiek@sumologic.com> * Fix default value used in tests Co-authored-by: Przemek Maciolek <pmaciolek@sumologic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Enable metrics pipeline for sumologicexporter. For now only prometheus format is supported. Rest of formats it's going to be implemented in future PRs
Link to tracking Issue:
#1498
Testing:
Unit tests
Documentation:
In-code comments