Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/file] add capability to replay metrics in time #19754

Merged
merged 1 commit into from
Mar 23, 2023
Merged

[receiver/file] add capability to replay metrics in time #19754

merged 1 commit into from
Mar 23, 2023

Conversation

pmcollins
Copy link
Member

Description: This change adds the ability to replay metrics at the same rate that they were originally received. (I also have a change to update the timestamps to current values but left that out for now to keep the diff smaller.)

Link to tracking Issue: #14638

Testing: Unit tests pass.

Documentation: Updated README with new capability and config field.

@runforesight
Copy link

runforesight bot commented Mar 16, 2023

Foresight Summary

    
Major Impacts

TestMySqlIntegration ❌ failed 1 times in 3 runs (33% fail rate).
TestMySqlIntegration/Running_mysql_version_8.0 ❌ failed 1 times in 3 runs (33% fail rate).
build-and-test-windows duration(7 seconds) has decreased 35 minutes 41 seconds compared to main branch avg(35 minutes 48 seconds).
View More Details

✅  telemetrygen workflow has finished in 1 minute (45 seconds less than main branch avg.) and finished at 17th Mar, 2023.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  check-links workflow has finished in 1 minute 35 seconds and finished at 17th Mar, 2023.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 3 minutes 25 seconds (3 minutes 48 seconds less than main branch avg.) and finished at 17th Mar, 2023.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  ✅ 21  ❌ 0  ⏭ 0    🔗 See Details

✅  e2e-tests workflow has finished in 11 minutes 26 seconds (3 minutes 44 seconds less than main branch avg.) and finished at 17th Mar, 2023.


Job Failed Steps Tests
kubernetes-test (v1.26.0) -     🔗  N/A See Details
kubernetes-test (v1.25.3) -     🔗  N/A See Details
kubernetes-test (v1.24.7) -     🔗  N/A See Details
kubernetes-test (v1.23.13) -     🔗  N/A See Details

✅  load-tests workflow has finished in 16 minutes 30 seconds (⚠️ 4 minutes 4 seconds more than main branch avg.) and finished at 17th Mar, 2023.


Job Failed Steps Tests
loadtest (TestIdleMode) -     🔗  ✅ 1  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceAttributesProcessor) -     🔗  ✅ 3  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  ✅ 6  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  ✅ 10  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  ✅ 8  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  ✅ 12  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  ✅ 18  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details

✅  build-and-test workflow has finished in 36 minutes 53 seconds (16 minutes 56 seconds less than main branch avg.) and finished at 18th Mar, 2023.


Job Failed Steps Tests
integration-tests -     🔗  ✅ 55  ❌ 0  ⏭ 0    🔗 See Details
cross-compile (darwin, amd64) -     🔗  N/A See Details
cross-compile (darwin, arm64) -     🔗  N/A See Details
cross-compile (linux, 386) -     🔗  N/A See Details
cross-compile (linux, amd64) -     🔗  N/A See Details
cross-compile (linux, arm) -     🔗  N/A See Details
cross-compile (linux, arm64) -     🔗  N/A See Details
cross-compile (linux, ppc64le) -     🔗  N/A See Details
cross-compile (windows, 386) -     🔗  N/A See Details
cross-compile (windows, amd64) -     🔗  N/A See Details
build-package (deb) -     🔗  N/A See Details
build-package (rpm) -     🔗  N/A See Details
windows-msi -     🔗  N/A See Details
publish-check -     🔗  N/A See Details
publish-dev -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

⭕  build-and-test-windows workflow has finished in 7 seconds (35 minutes 41 seconds less than main branch avg.) and finished at 23rd Mar, 2023.


Job Failed Steps Tests
windows-unittest -     🔗  N/A See Details
windows-unittest-matrix -     🔗  N/A See Details

✅  changelog workflow has finished in 2 minutes 9 seconds and finished at 23rd Mar, 2023.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

// by the timestamps on the input file's telemetry data. Higher values mean that
// replay will be slower by a corresponding amount. Use a value between 0 and 1
// to replay telemetry at a higher speed. Default: 1.
Throttle float64 `mapstructure:"throttle"`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm open to suggestions on this name.

Copy link
Contributor

@atoulme atoulme Mar 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe playback speed, similar to what youtube does?
Screenshot 2023-03-17 at 7 54 14 PM

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is what I went with originally but I wanted to be able to let users turn off replay timings completely without having to introduce a new config parameter -- they can do so by just setting throttle to 0. Would a playback_speed + some other config parameter to turn off timings be better?

@pmcollins pmcollins marked this pull request as ready for review March 17, 2023 15:08
@pmcollins pmcollins requested a review from a team March 17, 2023 15:08
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@atoulme atoulme added the ready to merge Code review completed; ready to merge by maintainers label Mar 23, 2023
@codeboten codeboten merged commit 2fe5b00 into open-telemetry:main Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers receiver/file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants