-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jaeger/receiver] Fix span status translation #19171
Merged
dmitryax
merged 1 commit into
open-telemetry:main
from
dmitryax:fix-jaeget-reciever-translation
Mar 1, 2023
Merged
[jaeger/receiver] Fix span status translation #19171
dmitryax
merged 1 commit into
open-telemetry:main
from
dmitryax:fix-jaeget-reciever-translation
Mar 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Foresight Summary
View More Details✅ check-links workflow has finished in 48 seconds (1 minute 45 seconds less than
|
Job | Failed Steps | Tests | |
---|---|---|---|
changed files | - 🔗 | N/A | See Details |
check-links | - 🔗 | N/A | See Details |
✅ telemetrygen workflow has finished in 1 minute 16 seconds (1 minute 55 seconds less than main
branch avg.) and finished at 1st Mar, 2023.
Job | Failed Steps | Tests | |
---|---|---|---|
build-dev | - 🔗 | N/A | See Details |
publish-latest | - 🔗 | N/A | See Details |
publish-stable | - 🔗 | N/A | See Details |
⭕ build-and-test-windows workflow has finished in 8 seconds (43 minutes 7 seconds less than main
branch avg.) and finished at 1st Mar, 2023.
Job | Failed Steps | Tests | |
---|---|---|---|
windows-unittest-matrix | - 🔗 | N/A | See Details |
windows-unittest | - 🔗 | N/A | See Details |
✅ changelog workflow has finished in 1 minute 29 seconds (1 minute 17 seconds less than main
branch avg.) and finished at 1st Mar, 2023.
Job | Failed Steps | Tests | |
---|---|---|---|
changelog | - 🔗 | N/A | See Details |
✅ prometheus-compliance-tests workflow has finished in 3 minutes 22 seconds (5 minutes 48 seconds less than main
branch avg.) and finished at 1st Mar, 2023.
Job | Failed Steps | Tests | |
---|---|---|---|
prometheus-compliance-tests | - 🔗 | ✅ 21 ❌ 0 ⏭ 0 🔗 | See Details |
✅ load-tests workflow has finished in 6 minutes 45 seconds (10 minutes 51 seconds less than main
branch avg.) and finished at 1st Mar, 2023.
Job | Failed Steps | Tests | |
---|---|---|---|
loadtest (TestIdleMode) | - 🔗 | ✅ 1 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestTraceAttributesProcessor) | - 🔗 | ✅ 3 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestMetric10kDPS|TestMetricsFromFile) | - 🔗 | ✅ 6 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) | - 🔗 | ✅ 8 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) | - 🔗 | ✅ 12 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) | - 🔗 | ✅ 10 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestBallastMemory|TestLog10kDPS) | - 🔗 | ✅ 18 ❌ 0 ⏭ 0 🔗 | See Details |
setup-environment | - 🔗 | N/A | See Details |
✅ e2e-tests workflow has finished in 12 minutes 35 seconds (4 minutes 5 seconds less than main
branch avg.) and finished at 1st Mar, 2023.
Job | Failed Steps | Tests | |
---|---|---|---|
kubernetes-test (v1.26.0) | - 🔗 | N/A | See Details |
kubernetes-test (v1.25.3) | - 🔗 | N/A | See Details |
kubernetes-test (v1.24.7) | - 🔗 | N/A | See Details |
kubernetes-test (v1.23.13) | - 🔗 | N/A | See Details |
build-and-test workflow has finished in 22 seconds (1 hour 11 minutes 35 seconds less than main
branch avg.) and finished at 1st Mar, 2023.
Job | Failed Steps | Tests | |
---|---|---|---|
unittest-matrix (1.19, exporter) | N/A | ✅ 2465 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.20, receiver-1) | N/A | ✅ 1937 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, other) | N/A | ✅ 4789 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, receiver-1) | N/A | ✅ 1937 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.20, other) | N/A | ✅ 4789 ❌ 0 ⏭ 0 🔗 | See Details |
*You can configure Foresight comments in your organization settings page.
jpkrohling
approved these changes
Mar 1, 2023
dmitryax
force-pushed
the
fix-jaeget-reciever-translation
branch
from
March 1, 2023 19:55
9803695
to
6db5385
Compare
dmitryax
force-pushed
the
fix-jaeget-reciever-translation
branch
from
March 1, 2023 20:43
6db5385
to
b47f10e
Compare
In jaeger->pdata translation, the OTel span status is set based on several sources, and one of them is span kind, but span kind is not set at the point when the status translation occurs, it's set right after that. This fix makes sure that span kind is set before the span status translation.
dmitryax
force-pushed
the
fix-jaeget-reciever-translation
branch
from
March 1, 2023 21:59
b47f10e
to
27c4098
Compare
Despite this having being merged, I would still appreciate a review from @frzifus |
frzifus
reviewed
Mar 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @jpkrohling - somehow this was lost on my github notifications. With @dmitryax explanation it makes sense to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In jaeger->pdata translation, the OTel span status is set based on several sources, and one of them is span kind, but span kind is not set at the point when the status translation occurs, it's set right after that. This fix makes sure that span kind is set before the span status translation.