Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jaeger/receiver] Fix span status translation #19171

Merged

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Mar 1, 2023

In jaeger->pdata translation, the OTel span status is set based on several sources, and one of them is span kind, but span kind is not set at the point when the status translation occurs, it's set right after that. This fix makes sure that span kind is set before the span status translation.

@runforesight
Copy link

runforesight bot commented Mar 1, 2023

Foresight Summary

    
Major Impacts

TestReceiveLogs ❌ failed 1 times in 7 runs (14% fail rate).
TestReceiveLogs/1_log_event_per_payload_(configured_max_content_length_is_same_as_event_size) ❌ failed 1 times in 7 runs (14% fail rate).
build-and-test duration(18 minutes 10 seconds) has decreased 53 minutes 47 seconds compared to main branch avg(1 hour 11 minutes 57 seconds).
View More Details

✅  check-links workflow has finished in 48 seconds (1 minute 45 seconds less than main branch avg.) and finished at 1st Mar, 2023.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  telemetrygen workflow has finished in 1 minute 16 seconds (1 minute 55 seconds less than main branch avg.) and finished at 1st Mar, 2023.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

⭕  build-and-test-windows workflow has finished in 8 seconds (43 minutes 7 seconds less than main branch avg.) and finished at 1st Mar, 2023.


Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

✅  changelog workflow has finished in 1 minute 29 seconds (1 minute 17 seconds less than main branch avg.) and finished at 1st Mar, 2023.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 3 minutes 22 seconds (5 minutes 48 seconds less than main branch avg.) and finished at 1st Mar, 2023.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  ✅ 21  ❌ 0  ⏭ 0    🔗 See Details

✅  load-tests workflow has finished in 6 minutes 45 seconds (10 minutes 51 seconds less than main branch avg.) and finished at 1st Mar, 2023.


Job Failed Steps Tests
loadtest (TestIdleMode) -     🔗  ✅ 1  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceAttributesProcessor) -     🔗  ✅ 3  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  ✅ 6  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  ✅ 8  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  ✅ 12  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  ✅ 10  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  ✅ 18  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details

✅  e2e-tests workflow has finished in 12 minutes 35 seconds (4 minutes 5 seconds less than main branch avg.) and finished at 1st Mar, 2023.


Job Failed Steps Tests
kubernetes-test (v1.26.0) -     🔗  N/A See Details
kubernetes-test (v1.25.3) -     🔗  N/A See Details
kubernetes-test (v1.24.7) -     🔗  N/A See Details
kubernetes-test (v1.23.13) -     🔗  N/A See Details

 build-and-test workflow has finished in 22 seconds (1 hour 11 minutes 35 seconds less than main branch avg.) and finished at 1st Mar, 2023.


Job Failed Steps Tests
unittest-matrix (1.19, exporter) N/A  ✅ 2465  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.20, receiver-1) N/A  ✅ 1937  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, other) N/A  ✅ 4789  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-1) N/A  ✅ 1937  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.20, other) N/A  ✅ 4789  ❌ 0  ⏭ 0    🔗 See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

@jpkrohling
Copy link
Member

@frzifus, this seems somewhat related to #12753, perhaps you could review this one as well? It looks good to me, but a second opinion would be good to have.

@dmitryax dmitryax force-pushed the fix-jaeget-reciever-translation branch from 9803695 to 6db5385 Compare March 1, 2023 19:55
@github-actions github-actions bot requested a review from jpkrohling March 1, 2023 19:56
@dmitryax dmitryax force-pushed the fix-jaeget-reciever-translation branch from 6db5385 to b47f10e Compare March 1, 2023 20:43
In jaeger->pdata translation, the OTel span status is set based on several sources, and one of them is span kind, but span kind is not set at the point when the status translation occurs, it's set right after that. This fix makes sure that span kind is set before the span status translation.
@dmitryax dmitryax force-pushed the fix-jaeget-reciever-translation branch from b47f10e to 27c4098 Compare March 1, 2023 21:59
@dmitryax dmitryax merged commit 1e56181 into open-telemetry:main Mar 1, 2023
@dmitryax dmitryax deleted the fix-jaeget-reciever-translation branch March 1, 2023 23:28
@jpkrohling
Copy link
Member

Despite this having being merged, I would still appreciate a review from @frzifus

Copy link
Member

@frzifus frzifus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @jpkrohling - somehow this was lost on my github notifications. With @dmitryax explanation it makes sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants