Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[telemetrygen] add makefile targets #18871

Merged
merged 2 commits into from
Feb 22, 2023

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Feb 22, 2023

Description:
Adds makefile targets for telemetrygen

Link to tracking Issue:
Fixes #18835

@atoulme atoulme requested review from a team and mx-psi February 22, 2023 06:12
@runforesight
Copy link

runforesight bot commented Feb 22, 2023

Foresight Summary

    
Major Impacts

build-and-test-windows duration(5 seconds) has decreased 42 minutes 43 seconds compared to main branch avg(42 minutes 48 seconds).
View More Details

⭕  build-and-test-windows workflow has finished in 5 seconds (42 minutes 43 seconds less than main branch avg.) and finished at 22nd Feb, 2023.


Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

✅  check-links workflow has finished in 41 seconds (1 minute 51 seconds less than main branch avg.) and finished at 22nd Feb, 2023.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  telemetrygen workflow has finished in 55 seconds (2 minutes 14 seconds less than main branch avg.) and finished at 22nd Feb, 2023.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  changelog workflow has finished in 1 minute 57 seconds (49 seconds less than main branch avg.) and finished at 22nd Feb, 2023.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 3 minutes 46 seconds (5 minutes 28 seconds less than main branch avg.) and finished at 22nd Feb, 2023.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  ✅ 21  ❌ 0  ⏭ 0    🔗 See Details

✅  load-tests workflow has finished in 15 minutes 4 seconds (2 minutes 22 seconds less than main branch avg.) and finished at 22nd Feb, 2023.


Job Failed Steps Tests
loadtest (TestTraceAttributesProcessor) -     🔗  ✅ 3  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestIdleMode) -     🔗  ✅ 1  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  ✅ 10  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  ✅ 6  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  ✅ 8  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  ✅ 18  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  N/A See Details

✅  e2e-tests workflow has finished in 13 minutes 13 seconds (2 minutes 42 seconds less than main branch avg.) and finished at 22nd Feb, 2023.


Job Failed Steps Tests
kubernetes-test (v1.26.0) -     🔗  N/A See Details
kubernetes-test (v1.25.3) -     🔗  N/A See Details
kubernetes-test (v1.24.7) -     🔗  N/A See Details
kubernetes-test (v1.23.13) -     🔗  N/A See Details

✅  build-and-test workflow has finished in 44 minutes 20 seconds (25 minutes 11 seconds less than main branch avg.) and finished at 22nd Feb, 2023.


Job Failed Steps Tests
lint-matrix (other) -     🔗  N/A See Details
lint -     🔗  N/A See Details
cross-compile (darwin, amd64) -     🔗  N/A See Details
cross-compile (darwin, arm64) -     🔗  N/A See Details
cross-compile (linux, 386) -     🔗  N/A See Details
cross-compile (linux, amd64) -     🔗  N/A See Details
cross-compile (linux, arm) -     🔗  N/A See Details
cross-compile (linux, arm64) -     🔗  N/A See Details
cross-compile (linux, ppc64le) -     🔗  N/A See Details
cross-compile (windows, 386) -     🔗  N/A See Details
cross-compile (windows, amd64) -     🔗  N/A See Details
build-package (deb) -     🔗  N/A See Details
build-package (rpm) -     🔗  N/A See Details
windows-msi -     🔗  N/A See Details
publish-check -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details
publish-dev -     🔗  N/A See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

@atoulme atoulme changed the title [telemetrygen] add makefile targets and github action [telemetrygen] add makefile targets Feb 22, 2023
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, but does this actually fix #18835? I think it fixes the first part, but it does not push it to Dockerhub, right?

@codeboten codeboten merged commit 09d8edf into open-telemetry:main Feb 22, 2023
@codeboten
Copy link
Contributor

Code LGTM, but does this actually fix #18835? I think it fixes the first part, but it does not push it to Dockerhub, right?

telemetrygen is published as part of publish-stable

@atoulme atoulme deleted the add_makefile_telemetrygen branch February 25, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[telemetrygen] make docker image and push to docker hub
4 participants