Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove go 1.18 support, bump minimum to go 1.19 and add testing for 1.20 #18436

Merged
merged 5 commits into from
Feb 15, 2023
Merged

remove go 1.18 support, bump minimum to go 1.19 and add testing for 1.20 #18436

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b8fb267
remove go 1.18 support, bump minimum to go 1.19 and add testing for 1.20
Feb 7, 2023
4be37da
add quotes around 1.20
Feb 8, 2023
46b9a95
update changelog
Feb 8, 2023
ad9b3f3
bump version of builder
Feb 8, 2023
e5fea26
update test to support 1.20 error message
Feb 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
update test to support 1.20 error message 
Signed-off-by: Alex Boten <aboten@lightstep.com>
  • Loading branch information
Alex Boten committed Feb 14, 2023
commit e5fea26e9068acdedd4b79671794f8fee92037ab
2 changes: 1 addition & 1 deletion receiver/jmxreceiver/receiver_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ func TestBuildOTLPReceiverInvalidEndpoints(t *testing.T) {
{
"invalid OTLPExporterConfig.Endpoint host with 0 port",
Config{OTLPExporterConfig: otlpExporterConfig{Endpoint: ".:0"}},
"failed determining desired port from OTLPExporterConfig.Endpoint .:0: listen tcp: lookup .:",
"failed determining desired port from OTLPExporterConfig.Endpoint .:0: listen tcp: lookup .",
},
}
for _, test := range tests {
Expand Down