Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] bump jaeger dependency #18400

Conversation

codeboten
Copy link
Contributor

@codeboten codeboten commented Feb 7, 2023

This addresses the following errors when updating the jaeger dep:

cd ./cmd/otelcontribcol && GO111MODULE=on CGO_ENABLED=0 go build -trimpath -o ../../bin/otelcontribcol_darwin_arm64 \
                -ldflags "-X github.com/open-telemetry/opentelemetry-collector-contrib/internal/otelcontribcore/internal/version.Version=v0.70.0-119-g4061bf6d6d" -tags "" .
../../receiver/jaegerreceiver/trace_receiver.go:185:43: cannot use (*notImplementedConfigManager)(nil) (value of type *notImplementedConfigManager) as type configmanager.ClientConfigManager in variable declaration:
        *notImplementedConfigManager does not implement configmanager.ClientConfigManager (wrong type for GetSamplingStrategy method)
                have GetSamplingStrategy(ctx context.Context, serviceName string) (*sampling.SamplingStrategyResponse, error)
                want GetSamplingStrategy(ctx context.Context, serviceName string) (*api_v2.SamplingStrategyResponse, error)
../../receiver/jaegerreceiver/trace_receiver.go:292:74: cannot use &notImplementedConfigManager{} (value of type *notImplementedConfigManager) as type configmanager.ClientConfigManager in argument to httpserver.NewHTTPServer:
        *notImplementedConfigManager does not implement configmanager.ClientConfigManager (wrong type for GetSamplingStrategy method)
                have GetSamplingStrategy(ctx context.Context, serviceName string) (*sampling.SamplingStrategyResponse, error)
                want GetSamplingStrategy(ctx context.Context, serviceName string) (*api_v2.SamplingStrategyResponse, error)
../../pkg/translator/zipkin/zipkinv1/thrift.go:38:47: not enough arguments in call to jaegerzipkin.DeserializeThrift
        have ([]byte)
        want (context.Context, []byte)
make: *** [otelcontribcol] Error 2

Fixes #18401

Signed-off-by: Alex Boten aboten@lightstep.com

This addresses the following errors when updating the jaeger dep:

```
cd ./cmd/otelcontribcol && GO111MODULE=on CGO_ENABLED=0 go build -trimpath -o ../../bin/otelcontribcol_darwin_arm64 \
                -ldflags "-X github.com/open-telemetry/opentelemetry-collector-contrib/internal/otelcontribcore/internal/version.Version=v0.70.0-119-g4061bf6d6d" -tags "" .
../../receiver/jaegerreceiver/trace_receiver.go:185:43: cannot use (*notImplementedConfigManager)(nil) (value of type *notImplementedConfigManager) as type configmanager.ClientConfigManager in variable declaration:
        *notImplementedConfigManager does not implement configmanager.ClientConfigManager (wrong type for GetSamplingStrategy method)
                have GetSamplingStrategy(ctx context.Context, serviceName string) (*sampling.SamplingStrategyResponse, error)
                want GetSamplingStrategy(ctx context.Context, serviceName string) (*api_v2.SamplingStrategyResponse, error)
../../receiver/jaegerreceiver/trace_receiver.go:292:74: cannot use &notImplementedConfigManager{} (value of type *notImplementedConfigManager) as type configmanager.ClientConfigManager in argument to httpserver.NewHTTPServer:
        *notImplementedConfigManager does not implement configmanager.ClientConfigManager (wrong type for GetSamplingStrategy method)
                have GetSamplingStrategy(ctx context.Context, serviceName string) (*sampling.SamplingStrategyResponse, error)
                want GetSamplingStrategy(ctx context.Context, serviceName string) (*api_v2.SamplingStrategyResponse, error)
../../pkg/translator/zipkin/zipkinv1/thrift.go:38:47: not enough arguments in call to jaegerzipkin.DeserializeThrift
        have ([]byte)
        want (context.Context, []byte)
make: *** [otelcontribcol] Error 2
```

Signed-off-by: Alex Boten <aboten@lightstep.com>
@runforesight
Copy link

runforesight bot commented Feb 7, 2023

Foresight Summary

    
Major Impacts

TestEndpointsAreWired ❌ failed 2 times in 2 runs (100% fail rate).
TestEndpointsAreWired/new ❌ failed 2 times in 2 runs (100% fail rate).
build-and-test-windows duration(5 seconds) has decreased 40 minutes 16 seconds compared to main branch avg(40 minutes 21 seconds).
View More Details

⭕  changelog workflow has finished in 4 seconds (2 minutes 2 seconds less than main branch avg.) and finished at 7th Feb, 2023.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

✅  check-links workflow has finished in 40 seconds (1 minute 31 seconds less than main branch avg.) and finished at 7th Feb, 2023.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  telemetrygen workflow has finished in 49 seconds (1 minute 48 seconds less than main branch avg.) and finished at 7th Feb, 2023.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

⭕  build-and-test-windows workflow has finished in 5 seconds (40 minutes 16 seconds less than main branch avg.) and finished at 7th Feb, 2023.


Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 3 minutes 20 seconds (4 minutes 43 seconds less than main branch avg.) and finished at 7th Feb, 2023.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  ✅ 21  ❌ 0  ⏭ 0    🔗 See Details

❌  build-and-test workflow has finished in 18 minutes 32 seconds (37 minutes 6 seconds less than main branch avg.) and finished at 7th Feb, 2023. 5 jobs failed. There are 4 test failures.


Job Failed Steps Tests
unittest-matrix (1.18, extension) Run Unit Tests     🔗  ✅ 195  ❌ 2  ⏭ 0    🔗 See Details
unittest-matrix (1.19, extension) Run Unit Tests     🔗  ✅ 195  ❌ 2  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-1) -     🔗  ✅ 297  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, internal) -     🔗  ✅ 483  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, other) -     🔗  ✅ 0  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, processor) -     🔗  ✅ 800  ❌ 0  ⏭ 0    🔗 See Details
correctness-metrics -     🔗  ✅ 2  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, processor) -     🔗  ✅ 800  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, exporter) -     🔗  ✅ 592  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-0) -     🔗  ✅ 453  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, receiver-1) -     🔗  ✅ 297  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, receiver-0) -     🔗  ✅ 547  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, other) -     🔗  ✅ 0  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, internal) -     🔗  ✅ 483  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, exporter) -     🔗  ✅ 592  ❌ 0  ⏭ 0    🔗 See Details
correctness-traces -     🔗  ✅ 17  ❌ 0  ⏭ 0    🔗 See Details
integration-tests -     🔗  ✅ 55  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details
check-collector-module-version -     🔗  N/A See Details
lint-matrix (receiver-0) -     🔗  N/A See Details
lint-matrix (receiver-1) Lint     🔗  N/A See Details
lint-matrix (processor) -     🔗  N/A See Details
lint-matrix (exporter) -     🔗  N/A See Details
lint-matrix (extension) -     🔗  N/A See Details
lint-matrix (internal) -     🔗  N/A See Details
lint-matrix (other) -     🔗  N/A See Details
checks -     🔗  N/A See Details
check-codeowners -     🔗  N/A See Details
build-examples -     🔗  N/A See Details
unittest (1.19) -     🔗  N/A See Details
unittest (1.18) Interpret result     🔗  N/A See Details
lint Interpret result     🔗  N/A See Details
cross-compile -     🔗  N/A See Details
windows-msi -     🔗  N/A See Details
build-package -     🔗  N/A See Details
publish-check -     🔗  N/A See Details
publish-dev -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  load-tests workflow has finished in 8 minutes 19 seconds (7 minutes 5 seconds less than main branch avg.) and finished at 7th Feb, 2023.


Job Failed Steps Tests
loadtest (TestTraceAttributesProcessor) -     🔗  ✅ 3  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestIdleMode) -     🔗  ✅ 1  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  ✅ 6  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  ✅ 8  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  ✅ 10  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  ✅ 12  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  ✅ 19  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details

✅  e2e-tests workflow has finished in 13 minutes 50 seconds (2 minutes 32 seconds less than main branch avg.) and finished at 7th Feb, 2023.


Job Failed Steps Tests
kubernetes-test -     🔗  N/A See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

Signed-off-by: Alex Boten <aboten@lightstep.com>
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Feb 22, 2023
@jpkrohling
Copy link
Member

@frzifus , @codeboten , is this still relevant?

@github-actions github-actions bot removed the Stale label Mar 3, 2023
Copy link
Contributor Author

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpkrohling yes this is currently blocked until #18485 gets merged

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label May 26, 2023
@mx-psi mx-psi added on hold This is blocked by another PR/issue and removed Stale labels May 29, 2023
@codeboten codeboten closed this Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump github.com/jaegertracing/jaeger from 1.41.0 to 1.42.0 causes issues
5 participants