Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clickhouse / string type cast fix #17564

Closed

Conversation

emreyalvac
Copy link
Contributor

Description:
Change Clickhouse string type cast function of insert flow.

Before this fix (check http.status_code):
{'http.method': 'GET', 'http.scheme': 'http', 'http.target': '/hc', 'http.url': 'url', 'http.flavor': '1.1', 'http.user_agent': 'Envoy/HC', 'http.status_code': '', 'net.host.name': 'url'}

After this fix (check http.status_code)::
{'http.method': 'GET', 'http.scheme': 'http', 'http.target': '/hc', 'http.url': 'url', 'http.flavor': '1.1', 'http.user_agent': 'Envoy/HC', 'http.status_code': '200', 'net.host.name': 'url'}

@emreyalvac emreyalvac requested a review from a team January 13, 2023 11:25
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 13, 2023

CLA Missing ID CLA Not Signed

@hanjm
Copy link
Member

hanjm commented Jan 13, 2023

Thanks. LGTM, Please add a changelog entry https://github.com/open-telemetry/opentelemetry-collector/blob/main/CONTRIBUTING.md#adding-a-changelog-entry

@emreyalvac
Copy link
Contributor Author

@hanjm can u review?

thanks.

@hanjm
Copy link
Member

hanjm commented Jan 17, 2023

@emreyalvac , seems CLA check not pass, please check your git config user.email is same as your github settings, then sign the CLA.

$ git config -l|grep user

@emreyalvac emreyalvac closed this Jan 17, 2023
@emreyalvac
Copy link
Contributor Author

#17834

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants