Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/snowflakereceiver] add client and config #17048

Merged
merged 8 commits into from
Dec 20, 2022

Conversation

shalper2
Copy link
Contributor

Description: Implementing client.go and config.go.

Link to tracking Issue: 14754

Testing: limited unit testing as missing factory.go limits the ability to test. Sql mocking for client.go.

Documentation: Added documentation referring to config.go including an example config.

@shalper2 shalper2 requested a review from a team December 15, 2022 17:01
@runforesight
Copy link

runforesight bot commented Dec 15, 2022

Foresight Summary

    
Major Impacts

build-and-test-windows duration(4 seconds) has decreased 43 minutes 42 seconds compared to main branch avg(43 minutes 46 seconds).
View More Details

⭕  build-and-test-windows workflow has finished in 4 seconds (43 minutes 35 seconds less than main branch avg.) and finished at 20th Dec, 2022.


Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

✅  check-links workflow has finished in 38 seconds (2 minutes 54 seconds less than main branch avg.) and finished at 20th Dec, 2022.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  tracegen workflow has finished in 56 seconds (2 minutes 57 seconds less than main branch avg.) and finished at 20th Dec, 2022.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  changelog workflow has finished in 1 minute 57 seconds (7 minutes 5 seconds less than main branch avg.) and finished at 20th Dec, 2022.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 10 minutes 50 seconds and finished at 20th Dec, 2022.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  ✅ 21  ❌ 0  ⏭ 0    🔗 See Details

✅  load-tests workflow has finished in 16 minutes 10 seconds and finished at 20th Dec, 2022.


Job Failed Steps Tests
loadtest (TestIdleMode) -     🔗  ✅ 1  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  ✅ 6  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  ✅ 8  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  ✅ 12  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  ✅ 19  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  ✅ 10  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceAttributesProcessor) -     🔗  ✅ 3  ❌ 0  ⏭ 0    🔗 See Details

✅  build-and-test workflow has finished in 34 minutes 38 seconds (25 minutes 27 seconds less than main branch avg.) and finished at 20th Dec, 2022.


Job Failed Steps Tests
unittest-matrix (1.19, receiver-1) -     🔗  ✅ 1871  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details
check-collector-module-version -     🔗  N/A See Details
lint-matrix (receiver-0) -     🔗  N/A See Details
lint-matrix (receiver-1) -     🔗  N/A See Details
lint-matrix (processor) -     🔗  N/A See Details
lint-matrix (exporter) -     🔗  N/A See Details
lint-matrix (extension) -     🔗  N/A See Details
lint-matrix (internal) -     🔗  N/A See Details
lint-matrix (other) -     🔗  N/A See Details
checks -     🔗  N/A See Details
check-codeowners -     🔗  N/A See Details
integration-tests -     🔗  N/A See Details
unittest-matrix (1.19, receiver-0) -     🔗  N/A See Details
unittest-matrix (1.19, processor) -     🔗  N/A See Details
unittest-matrix (1.19, exporter) -     🔗  N/A See Details
unittest-matrix (1.19, extension) -     🔗  N/A See Details
unittest-matrix (1.19, internal) -     🔗  N/A See Details
unittest-matrix (1.19, other) -     🔗  N/A See Details
unittest-matrix (1.18, receiver-0) -     🔗  N/A See Details
unittest-matrix (1.18, receiver-1) -     🔗  N/A See Details
unittest-matrix (1.18, processor) -     🔗  N/A See Details
unittest-matrix (1.18, exporter) -     🔗  N/A See Details
unittest-matrix (1.18, extension) -     🔗  N/A See Details
unittest-matrix (1.18, internal) -     🔗  N/A See Details
unittest-matrix (1.18, other) -     🔗  N/A See Details
build-examples -     🔗  N/A See Details
correctness-metrics -     🔗  N/A See Details
correctness-traces -     🔗  N/A See Details
lint -     🔗  N/A See Details
unittest (1.19) -     🔗  N/A See Details
unittest (1.18) -     🔗  N/A See Details
cross-compile (darwin, amd64) -     🔗  N/A See Details
cross-compile (darwin, arm64) -     🔗  N/A See Details
cross-compile (linux, 386) -     🔗  N/A See Details
cross-compile (linux, amd64) -     🔗  N/A See Details
cross-compile (linux, arm) -     🔗  N/A See Details
cross-compile (linux, arm64) -     🔗  N/A See Details
cross-compile (linux, ppc64le) -     🔗  N/A See Details
cross-compile (windows, 386) -     🔗  N/A See Details
cross-compile (windows, amd64) -     🔗  N/A See Details
build-package (deb) -     🔗  N/A See Details
build-package (rpm) -     🔗  N/A See Details
windows-msi -     🔗  N/A See Details
publish-check -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details
publish-dev -     🔗  N/A See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

@dmitryax
Copy link
Member

@shalper2 I'll review it in detail tomorrow. Please rebase and make sure all tests pass. I see at least one lint job is failing. Rebase is needed because we've just recovered the broken CI #17037

Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks pretty good. Just a couple of nits. And please rebase so we can merge it

receiver/snowflakereceiver/client.go Outdated Show resolved Hide resolved
receiver/snowflakereceiver/client.go Outdated Show resolved Hide resolved
@dmitryax dmitryax merged commit d777e30 into open-telemetry:main Dec 20, 2022
@shalper2 shalper2 deleted the snowflake_add_client branch June 12, 2023 14:02
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
receiver/snowflake Snowflake receiver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants