Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] remove unnecessary componenttest.NewNopFactories usages in tests #17008

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

bogdandrutu
Copy link
Member

No description provided.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@runforesight
Copy link

runforesight bot commented Dec 13, 2022

Foresight Summary

    
Major Impacts

TestConsumeLogsUnexpectedExporterType ❌ failed 2 times in 2 runs (100% fail rate).
TestConsumeTracesUnexpectedExporterType ❌ failed 2 times in 2 runs (100% fail rate).
TestLoadInvalidConfig_NoScrapers ❌ failed 2 times in 2 runs (100% fail rate).
View More Details

⭕  changelog workflow has finished in 4 seconds (7 minutes 22 seconds less than main branch avg.) and finished at 13th Dec, 2022.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

⭕  build-and-test-windows workflow has finished in 5 seconds (39 minutes 46 seconds less than main branch avg.) and finished at 13th Dec, 2022.


Job Failed Steps Tests
windows-unittest -     🔗  N/A See Details

✅  tracegen workflow has finished in 1 minute 37 seconds (2 minutes 3 seconds less than main branch avg.) and finished at 13th Dec, 2022.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  check-links workflow has finished in 1 minute 53 seconds (1 minute 27 seconds less than main branch avg.) and finished at 13th Dec, 2022.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 3 minutes 41 seconds (5 minutes 48 seconds less than main branch avg.) and finished at 13th Dec, 2022.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  ✅ 21  ❌ 0  ⏭ 0    🔗 See Details

 build-and-test workflow has finished in 34 minutes 25 seconds (26 minutes 43 seconds less than main branch avg.) and finished at 13th Dec, 2022. There are 8 test failures.


Job Failed Steps Tests
unittest-matrix (1.18, internal) N/A  ✅ 592  ❌ 0  ⏭ 0    🔗 See Details
correctness-traces N/A  ✅ 17  ❌ 0  ⏭ 0    🔗 See Details
correctness-metrics N/A  ✅ 2  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, extension) N/A  ✅ 528  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, extension) N/A  ✅ 528  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, processor) N/A  ✅ 1465  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, receiver-0) N/A  ✅ 2532  ❌ 1  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-0) N/A  ✅ 2532  ❌ 1  ⏭ 0    🔗 See Details
unittest-matrix (1.19, internal) N/A  ✅ 592  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, exporter) N/A  ✅ 2237  ❌ 2  ⏭ 0    🔗 See Details
unittest-matrix (1.18, receiver-1) N/A  ✅ 1853  ❌ 1  ⏭ 0    🔗 See Details
unittest-matrix (1.19, exporter) N/A  ✅ 2237  ❌ 2  ⏭ 0    🔗 See Details
integration-tests N/A  ✅ 47  ❌ 1  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-1) N/A  ✅ 1854  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, other) N/A  ✅ 4363  ❌ 0  ⏭ 0    🔗 See Details

✅  load-tests workflow has finished in 25 minutes 59 seconds (⚠️ 9 minutes 26 seconds more than main branch avg.) and finished at 13th Dec, 2022.


Job Failed Steps Tests
loadtest (TestTraceAttributesProcessor) -     🔗  ✅ 3  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestIdleMode) -     🔗  ✅ 1  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  ✅ 12  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  ✅ 6  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  ✅ 10  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  ✅ 8  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  ✅ 19  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

@bogdandrutu bogdandrutu merged commit 844811e into open-telemetry:main Dec 13, 2022
@bogdandrutu bogdandrutu deleted the rmunnecessarynopfact branch December 13, 2022 16:55
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants