Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper library that splits an incoming data based on an attribute… #1694

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

bogdandrutu
Copy link
Member

… in the Resource

Currently works only with string values.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com

… in the Resource

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu requested a review from a team November 24, 2020 15:16
@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #1694 (6727b87) into master (0bf5215) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1694      +/-   ##
==========================================
- Coverage   89.41%   89.40%   -0.01%     
==========================================
  Files         370      370              
  Lines       18141    18141              
==========================================
- Hits        16220    16219       -1     
- Misses       1431     1432       +1     
  Partials      490      490              
Flag Coverage Δ
integration 70.97% <ø> (-0.07%) ⬇️
unit 88.09% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
receiver/carbonreceiver/transport/tcp_server.go 66.00% <0.00%> (-1.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bf5215...6727b87. Read the comment docs.

Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bogdandrutu bogdandrutu merged commit 3a50409 into open-telemetry:master Nov 25, 2020
@bogdandrutu bogdandrutu deleted the batchres branch November 25, 2020 14:51
dyladan referenced this pull request in dynatrace-oss-contrib/opentelemetry-collector-contrib Jan 29, 2021
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants