Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/resourcedetection] [chore] Remove redundant pdata helpers and OC dependency in tests #16599

Merged

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Dec 3, 2022

No description provided.

@dmitryax dmitryax requested a review from a team December 3, 2022 10:16
@github-actions github-actions bot added the processor/resourcedetection Resource detection processor label Dec 3, 2022
@runforesight
Copy link

runforesight bot commented Dec 3, 2022

Foresight Summary

    
Major Impacts

TestDetect ❌ failed 4 times in 8 runs (50% fail rate).
View More Details

⭕  build-and-test-windows workflow has finished in 5 seconds (32 minutes 53 seconds less than main branch avg.) and finished at 3rd Dec, 2022.


Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

⭕  changelog workflow has finished in 4 seconds (4 minutes 58 seconds less than main branch avg.) and finished at 3rd Dec, 2022.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

✅  check-links workflow has finished in 40 seconds (1 minute 20 seconds less than main branch avg.) and finished at 3rd Dec, 2022.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  tracegen workflow has finished in 1 minute 3 seconds (1 minute 11 seconds less than main branch avg.) and finished at 3rd Dec, 2022.


Job Failed Steps Tests
publish-latest -     🔗  N/A See Details
build-dev -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 3 minutes 20 seconds (4 minutes 34 seconds less than main branch avg.) and finished at 3rd Dec, 2022.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  ✅ 21  ❌ 0  ⏭ 0    🔗 See Details

 load-tests workflow has finished in 2 minutes 31 seconds (11 minutes 17 seconds less than main branch avg.) and finished at 3rd Dec, 2022.


Job Failed Steps Tests
loadtest (TestTraceAttributesProcessor) N/A  ✅ 3  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestIdleMode) N/A  ✅ 1  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) N/A  ✅ 6  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) N/A  ✅ 10  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) N/A  ✅ 12  ❌ 0  ⏭ 0    🔗 See Details

 build-and-test workflow has finished in 6 minutes 12 seconds (47 minutes 31 seconds less than main branch avg.) and finished at 3rd Dec, 2022. There are 1 test failures.


Job Failed Steps Tests
unittest-matrix (1.18, internal) N/A  ✅ 592  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, processor) N/A  ✅ 927  ❌ 1  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-1) N/A  ✅ 274  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, extension) N/A  ✅ 375  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, other) N/A  ✅ 0  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, exporter) N/A  ✅ 557  ❌ 0  ⏭ 0    🔗 See Details
correctness-traces N/A  ✅ 0  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-0) N/A  ✅ 162  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, receiver-0) N/A  ✅ 169  ❌ 0  ⏭ 0    🔗 See Details
correctness-metrics N/A  ✅ 0  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, extension) N/A  ✅ 152  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, processor) N/A  ✅ 736  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, internal) N/A  ✅ 169  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, other) N/A  ✅ 0  ❌ 0  ⏭ 0    🔗 See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

@dmitryax dmitryax force-pushed the resdetect-remove-pdata-helpers branch 2 times, most recently from 9d338fa to 01456ef Compare December 3, 2022 16:53
@github-actions github-actions bot added the exporter/datadog Datadog components label Dec 3, 2022
@dmitryax dmitryax changed the title [processor/resourcedetection] [chore] Remove redundant pdata helpers [processor/resourcedetection] [chore] Remove redundant pdata helpers and OC dependency Dec 3, 2022
@dmitryax dmitryax force-pushed the resdetect-remove-pdata-helpers branch 2 times, most recently from 1ecc401 to bcebdd9 Compare December 3, 2022 22:54
@dmitryax dmitryax changed the title [processor/resourcedetection] [chore] Remove redundant pdata helpers and OC dependency [processor/resourcedetection] [chore] Remove redundant pdata helpers and OC dependency in tests Dec 3, 2022
@runforesight
Copy link

runforesight bot commented Dec 3, 2022

Foresight Summary

    
Major Impacts

build-and-test-windows duration(4 seconds) has decreased 32 minutes 54 seconds compared to main branch avg(32 minutes 58 seconds).
View More Details

⭕  changelog workflow has finished in 3 seconds (4 minutes 59 seconds less than main branch avg.) and finished at 4th Dec, 2022.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

✅  check-links workflow has finished in 40 seconds (1 minute 20 seconds less than main branch avg.) and finished at 4th Dec, 2022.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

⭕  build-and-test-windows workflow has finished in 4 seconds (32 minutes 54 seconds less than main branch avg.) and finished at 4th Dec, 2022.


Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

✅  tracegen workflow has finished in 57 seconds (1 minute 17 seconds less than main branch avg.) and finished at 4th Dec, 2022.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 3 minutes 23 seconds (4 minutes 31 seconds less than main branch avg.) and finished at 4th Dec, 2022.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  ✅ 21  ❌ 0  ⏭ 0    🔗 See Details

✅  load-tests workflow has finished in 8 minutes 15 seconds (5 minutes 33 seconds less than main branch avg.) and finished at 4th Dec, 2022.


Job Failed Steps Tests
loadtest (TestTraceAttributesProcessor) -     🔗  ✅ 3  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestIdleMode) -     🔗  ✅ 1  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  ✅ 8  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  ✅ 6  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  ✅ 10  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  ✅ 12  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  ✅ 19  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details

✅  build-and-test workflow has finished in 37 minutes 16 seconds (16 minutes 27 seconds less than main branch avg.) and finished at 4th Dec, 2022.


Job Failed Steps Tests
integration-tests -     🔗  ✅ 59  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details
check-codeowners -     🔗  N/A See Details
build-examples -     🔗  N/A See Details
check-collector-module-version -     🔗  N/A See Details
checks -     🔗  N/A See Details
correctness-metrics -     🔗  N/A See Details
correctness-traces -     🔗  N/A See Details
lint-matrix (receiver-0) -     🔗  N/A See Details
lint-matrix (receiver-1) -     🔗  N/A See Details
lint-matrix (processor) -     🔗  N/A See Details
lint-matrix (exporter) -     🔗  N/A See Details
lint-matrix (extension) -     🔗  N/A See Details
lint-matrix (internal) -     🔗  N/A See Details
lint-matrix (other) -     🔗  N/A See Details
unittest-matrix (1.19, receiver-0) -     🔗  N/A See Details
unittest-matrix (1.19, receiver-1) -     🔗  N/A See Details
unittest-matrix (1.19, processor) -     🔗  N/A See Details
unittest-matrix (1.19, exporter) -     🔗  N/A See Details
unittest-matrix (1.19, extension) -     🔗  N/A See Details
unittest-matrix (1.19, internal) -     🔗  N/A See Details
unittest-matrix (1.19, other) -     🔗  N/A See Details
unittest-matrix (1.18, receiver-0) -     🔗  N/A See Details
unittest-matrix (1.18, receiver-1) -     🔗  N/A See Details
unittest-matrix (1.18, processor) -     🔗  N/A See Details
unittest-matrix (1.18, exporter) -     🔗  N/A See Details
unittest-matrix (1.18, extension) -     🔗  N/A See Details
unittest-matrix (1.18, internal) -     🔗  N/A See Details
unittest-matrix (1.18, other) -     🔗  N/A See Details
lint -     🔗  N/A See Details
unittest (1.19) -     🔗  N/A See Details
unittest (1.18) -     🔗  N/A See Details
cross-compile (darwin, amd64) -     🔗  N/A See Details
cross-compile (darwin, arm64) -     🔗  N/A See Details
cross-compile (linux, 386) -     🔗  N/A See Details
cross-compile (linux, amd64) -     🔗  N/A See Details
cross-compile (linux, arm) -     🔗  N/A See Details
cross-compile (linux, arm64) -     🔗  N/A See Details
cross-compile (linux, ppc64le) -     🔗  N/A See Details
cross-compile (windows, 386) -     🔗  N/A See Details
cross-compile (windows, amd64) -     🔗  N/A See Details
build-package (deb) -     🔗  N/A See Details
build-package (rpm) -     🔗  N/A See Details
windows-msi -     🔗  N/A See Details
publish-check -     🔗  N/A See Details
publish-dev -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

@dmitryax dmitryax force-pushed the resdetect-remove-pdata-helpers branch from bcebdd9 to 10426b5 Compare December 4, 2022 07:03
@bogdandrutu bogdandrutu merged commit e58554a into open-telemetry:main Dec 5, 2022
@dmitryax dmitryax deleted the resdetect-remove-pdata-helpers branch December 5, 2022 21:15
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
…and OC dependency in tests (open-telemetry#16599)

[processor/resourcedetection] [chore] Remove redundant pdata helpers
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/datadog Datadog components processor/resourcedetection Resource detection processor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants