-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[processor/resourcedetection] [chore] Remove redundant pdata helpers and OC dependency in tests #16599
Merged
bogdandrutu
merged 1 commit into
open-telemetry:main
from
dmitryax:resdetect-remove-pdata-helpers
Dec 5, 2022
Merged
[processor/resourcedetection] [chore] Remove redundant pdata helpers and OC dependency in tests #16599
bogdandrutu
merged 1 commit into
open-telemetry:main
from
dmitryax:resdetect-remove-pdata-helpers
Dec 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Foresight Summary
View More Details⭕ build-and-test-windows workflow has finished in 5 seconds (32 minutes 53 seconds less than
|
Job | Failed Steps | Tests | |
---|---|---|---|
windows-unittest-matrix | - 🔗 | N/A | See Details |
windows-unittest | - 🔗 | N/A | See Details |
⭕ changelog workflow has finished in 4 seconds (4 minutes 58 seconds less than main
branch avg.) and finished at 3rd Dec, 2022.
Job | Failed Steps | Tests | |
---|---|---|---|
changelog | - 🔗 | N/A | See Details |
✅ check-links workflow has finished in 40 seconds (1 minute 20 seconds less than main
branch avg.) and finished at 3rd Dec, 2022.
Job | Failed Steps | Tests | |
---|---|---|---|
changed files | - 🔗 | N/A | See Details |
check-links | - 🔗 | N/A | See Details |
✅ tracegen workflow has finished in 1 minute 3 seconds (1 minute 11 seconds less than main
branch avg.) and finished at 3rd Dec, 2022.
Job | Failed Steps | Tests | |
---|---|---|---|
publish-latest | - 🔗 | N/A | See Details |
build-dev | - 🔗 | N/A | See Details |
publish-stable | - 🔗 | N/A | See Details |
✅ prometheus-compliance-tests workflow has finished in 3 minutes 20 seconds (4 minutes 34 seconds less than main
branch avg.) and finished at 3rd Dec, 2022.
Job | Failed Steps | Tests | |
---|---|---|---|
prometheus-compliance-tests | - 🔗 | ✅ 21 ❌ 0 ⏭ 0 🔗 | See Details |
load-tests workflow has finished in 2 minutes 31 seconds (11 minutes 17 seconds less than main
branch avg.) and finished at 3rd Dec, 2022.
Job | Failed Steps | Tests | |
---|---|---|---|
loadtest (TestTraceAttributesProcessor) | N/A | ✅ 3 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestIdleMode) | N/A | ✅ 1 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestMetric10kDPS|TestMetricsFromFile) | N/A | ✅ 6 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) | N/A | ✅ 10 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) | N/A | ✅ 12 ❌ 0 ⏭ 0 🔗 | See Details |
build-and-test workflow has finished in 6 minutes 12 seconds (47 minutes 31 seconds less than main
branch avg.) and finished at 3rd Dec, 2022. There are 1 test failures.
Job | Failed Steps | Tests | |
---|---|---|---|
unittest-matrix (1.18, internal) | N/A | ✅ 592 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, processor) | N/A | ✅ 927 ❌ 1 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, receiver-1) | N/A | ✅ 274 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, extension) | N/A | ✅ 375 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, other) | N/A | ✅ 0 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, exporter) | N/A | ✅ 557 ❌ 0 ⏭ 0 🔗 | See Details |
correctness-traces | N/A | ✅ 0 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, receiver-0) | N/A | ✅ 162 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, receiver-0) | N/A | ✅ 169 ❌ 0 ⏭ 0 🔗 | See Details |
correctness-metrics | N/A | ✅ 0 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, extension) | N/A | ✅ 152 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, processor) | N/A | ✅ 736 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, internal) | N/A | ✅ 169 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, other) | N/A | ✅ 0 ❌ 0 ⏭ 0 🔗 | See Details |
*You can configure Foresight comments in your organization settings page.
9d338fa
to
01456ef
Compare
1ecc401
to
bcebdd9
Compare
Foresight Summary
View More Details⭕ changelog workflow has finished in 3 seconds (4 minutes 59 seconds less than
|
Job | Failed Steps | Tests | |
---|---|---|---|
changelog | - 🔗 | N/A | See Details |
✅ check-links workflow has finished in 40 seconds (1 minute 20 seconds less than main
branch avg.) and finished at 4th Dec, 2022.
Job | Failed Steps | Tests | |
---|---|---|---|
changed files | - 🔗 | N/A | See Details |
check-links | - 🔗 | N/A | See Details |
⭕ build-and-test-windows workflow has finished in 4 seconds (32 minutes 54 seconds less than main
branch avg.) and finished at 4th Dec, 2022.
Job | Failed Steps | Tests | |
---|---|---|---|
windows-unittest-matrix | - 🔗 | N/A | See Details |
windows-unittest | - 🔗 | N/A | See Details |
✅ tracegen workflow has finished in 57 seconds (1 minute 17 seconds less than main
branch avg.) and finished at 4th Dec, 2022.
Job | Failed Steps | Tests | |
---|---|---|---|
build-dev | - 🔗 | N/A | See Details |
publish-latest | - 🔗 | N/A | See Details |
publish-stable | - 🔗 | N/A | See Details |
✅ prometheus-compliance-tests workflow has finished in 3 minutes 23 seconds (4 minutes 31 seconds less than main
branch avg.) and finished at 4th Dec, 2022.
Job | Failed Steps | Tests | |
---|---|---|---|
prometheus-compliance-tests | - 🔗 | ✅ 21 ❌ 0 ⏭ 0 🔗 | See Details |
✅ load-tests workflow has finished in 8 minutes 15 seconds (5 minutes 33 seconds less than main
branch avg.) and finished at 4th Dec, 2022.
Job | Failed Steps | Tests | |
---|---|---|---|
loadtest (TestTraceAttributesProcessor) | - 🔗 | ✅ 3 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestIdleMode) | - 🔗 | ✅ 1 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) | - 🔗 | ✅ 8 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestMetric10kDPS|TestMetricsFromFile) | - 🔗 | ✅ 6 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) | - 🔗 | ✅ 10 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) | - 🔗 | ✅ 12 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestBallastMemory|TestLog10kDPS) | - 🔗 | ✅ 19 ❌ 0 ⏭ 0 🔗 | See Details |
setup-environment | - 🔗 | N/A | See Details |
✅ build-and-test workflow has finished in 37 minutes 16 seconds (16 minutes 27 seconds less than main
branch avg.) and finished at 4th Dec, 2022.
Job | Failed Steps | Tests | |
---|---|---|---|
integration-tests | - 🔗 | ✅ 59 ❌ 0 ⏭ 0 🔗 | See Details |
setup-environment | - 🔗 | N/A | See Details |
check-codeowners | - 🔗 | N/A | See Details |
build-examples | - 🔗 | N/A | See Details |
check-collector-module-version | - 🔗 | N/A | See Details |
checks | - 🔗 | N/A | See Details |
correctness-metrics | - 🔗 | N/A | See Details |
correctness-traces | - 🔗 | N/A | See Details |
lint-matrix (receiver-0) | - 🔗 | N/A | See Details |
lint-matrix (receiver-1) | - 🔗 | N/A | See Details |
lint-matrix (processor) | - 🔗 | N/A | See Details |
lint-matrix (exporter) | - 🔗 | N/A | See Details |
lint-matrix (extension) | - 🔗 | N/A | See Details |
lint-matrix (internal) | - 🔗 | N/A | See Details |
lint-matrix (other) | - 🔗 | N/A | See Details |
unittest-matrix (1.19, receiver-0) | - 🔗 | N/A | See Details |
unittest-matrix (1.19, receiver-1) | - 🔗 | N/A | See Details |
unittest-matrix (1.19, processor) | - 🔗 | N/A | See Details |
unittest-matrix (1.19, exporter) | - 🔗 | N/A | See Details |
unittest-matrix (1.19, extension) | - 🔗 | N/A | See Details |
unittest-matrix (1.19, internal) | - 🔗 | N/A | See Details |
unittest-matrix (1.19, other) | - 🔗 | N/A | See Details |
unittest-matrix (1.18, receiver-0) | - 🔗 | N/A | See Details |
unittest-matrix (1.18, receiver-1) | - 🔗 | N/A | See Details |
unittest-matrix (1.18, processor) | - 🔗 | N/A | See Details |
unittest-matrix (1.18, exporter) | - 🔗 | N/A | See Details |
unittest-matrix (1.18, extension) | - 🔗 | N/A | See Details |
unittest-matrix (1.18, internal) | - 🔗 | N/A | See Details |
unittest-matrix (1.18, other) | - 🔗 | N/A | See Details |
lint | - 🔗 | N/A | See Details |
unittest (1.19) | - 🔗 | N/A | See Details |
unittest (1.18) | - 🔗 | N/A | See Details |
cross-compile (darwin, amd64) | - 🔗 | N/A | See Details |
cross-compile (darwin, arm64) | - 🔗 | N/A | See Details |
cross-compile (linux, 386) | - 🔗 | N/A | See Details |
cross-compile (linux, amd64) | - 🔗 | N/A | See Details |
cross-compile (linux, arm) | - 🔗 | N/A | See Details |
cross-compile (linux, arm64) | - 🔗 | N/A | See Details |
cross-compile (linux, ppc64le) | - 🔗 | N/A | See Details |
cross-compile (windows, 386) | - 🔗 | N/A | See Details |
cross-compile (windows, amd64) | - 🔗 | N/A | See Details |
build-package (deb) | - 🔗 | N/A | See Details |
build-package (rpm) | - 🔗 | N/A | See Details |
windows-msi | - 🔗 | N/A | See Details |
publish-check | - 🔗 | N/A | See Details |
publish-dev | - 🔗 | N/A | See Details |
publish-stable | - 🔗 | N/A | See Details |
*You can configure Foresight comments in your organization settings page.
bcebdd9
to
10426b5
Compare
bogdandrutu
approved these changes
Dec 5, 2022
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
…and OC dependency in tests (open-telemetry#16599) [processor/resourcedetection] [chore] Remove redundant pdata helpers
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.