Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purestorage FlashArray Receiver First Scraper #16529

Conversation

dgoscn
Copy link
Contributor

@dgoscn dgoscn commented Nov 29, 2022

Description:
This PR it is related to the first implementation of one of the scrapers belonging to FlashArray Receiver

Link to tracking Issue:
#14886

Testing:
Simple functional testing as with other components using make test on the root of the opentelemetry-collector-contrib and the use of verbose go test inside the receiver/purefareceiver

Documentation:
The documentation still in development. It is possible to follow the doc displayed on README.md inside the receiver/purefareceiver project.

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@dgoscn dgoscn closed this Nov 29, 2022
@dgoscn dgoscn reopened this Nov 29, 2022
@jpkrohling jpkrohling force-pushed the purestorage_flasharray_receiver_initial_scraper branch from 5cfc1fe to 0b46918 Compare November 29, 2022 23:07
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactoring will be due on the next scraper but looks good so far.

@jpkrohling jpkrohling added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 29, 2022
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@jpkrohling jpkrohling merged commit 870f399 into open-telemetry:main Nov 30, 2022
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants