-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Purestorage FlashArray Receiver First Scraper #16529
Merged
jpkrohling
merged 6 commits into
open-telemetry:main
from
dgoscn:purestorage_flasharray_receiver_initial_scraper
Nov 30, 2022
Merged
Purestorage FlashArray Receiver First Scraper #16529
jpkrohling
merged 6 commits into
open-telemetry:main
from
dgoscn:purestorage_flasharray_receiver_initial_scraper
Nov 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
jpkrohling
force-pushed
the
purestorage_flasharray_receiver_initial_scraper
branch
from
November 29, 2022 23:07
5cfc1fe
to
0b46918
Compare
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
jpkrohling
approved these changes
Nov 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactoring will be due on the next scraper but looks good so far.
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
6 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR it is related to the first implementation of one of the scrapers belonging to FlashArray Receiver
Link to tracking Issue:
#14886
Testing:
Simple functional testing as with other components using
make test
on the root of theopentelemetry-collector-contrib
and the use of verbosego test
inside thereceiver/purefareceiver
Documentation:
The documentation still in development. It is possible to follow the doc displayed on README.md inside the
receiver/purefareceiver
project.