Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Disable flaky windows file rotation tests #16332

Merged
merged 1 commit into from
Nov 16, 2022
Merged

[chore] Disable flaky windows file rotation tests #16332

merged 1 commit into from
Nov 16, 2022

Conversation

djaglowski
Copy link
Member

See #16331

@codeboten
Copy link
Contributor

Saw another example of this:

--- FAIL: TestRotation (14.19s)
    --- PASS: TestRotation/NoRotation/CopyTruncateTimestamped (0.41s)
    --- FAIL: TestRotation/NoRotation/CopyTruncateSequential (0.63s)

@djaglowski djaglowski marked this pull request as ready for review November 16, 2022 20:27
@djaglowski djaglowski requested review from a team and MovieStoreGuy November 16, 2022 20:27
@codeboten codeboten merged commit f36fd9d into open-telemetry:main Nov 16, 2022
@djaglowski djaglowski deleted the pkg-stanza-skip-windows-rotation branch November 16, 2022 21:17
JaredTan95 pushed a commit to openinsight-proj/opentelemetry-collector-contrib that referenced this pull request Nov 21, 2022
@djaglowski @JaredTan95
[chore] Disable flaky windows file rotation tests (open-telemetry#16332)
4f5f41c
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
@djaglowski @shalper2
[chore] Disable flaky windows file rotation tests (open-telemetry#16332)
1a50c17
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@MovieStoreGuy MovieStoreGuy Awaiting requested review from MovieStoreGuy

Assignees

@TylerHelmuth TylerHelmuth

Labels
pkg/stanza
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djaglowski @codeboten @TylerHelmuth