[exporter/datadog] Simplify and add tags to logs from Datadog Exporter #16080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dineshg13
suggested changes
Nov 4, 2022
liustanley
changed the title
mx-psi
reviewed
Nov 8, 2022
liustanley
requested review from
mx-psi and
dineshg13
and removed request for
dineshg13 and
mx-psi
dineshg13
suggested changes
Nov 8, 2022
| @@ -52,6 +52,7 @@ require ( | |||
| github.com/Showmax/go-fqdn v1.0.0 // indirect | |||
| github.com/antonmedv/expr v1.9.0 // indirect | |||
| github.com/armon/go-metrics v0.3.10 // indirect | |||
| github.com/benbjohnson/clock v1.3.0 // indirect | |||
There was a problem hiding this comment.
This got added when I imported "go.uber.org/zap/zaptest" in translator_test.go
mx-psi
approved these changes
Nov 9, 2022
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
open-telemetry#16080) * Adding logic to translator * Fix trace id transform and add tests * Tags change and tests * Address requested changes * Add otel tag to logs exporter tests * Fix tags issue by setting ddtags in sender opts * Address PR changes * Change tag name and add changelog * Address PR comments * Fix if else structure * Remove logs * Fix clean up
6 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
otel_source:datadog_exportertag for logs sent from exporterattribute->tagconversion #15387 by appending to tags in attributes instead of replacing themLink to tracking Issue: #15387
Testing: Added unit tests in
translator_test.go