Enable unconvert linter, fix errors #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
requested review from
anuraaga,
james-bebbington,
jpkrohling,
jrcamp,
kbrockhoff and
owais
as code owners
bogdandrutu
force-pushed
the
unspasadsa
branch
from
42e366d to
de3644a
Compare
Codecov Report
@@ Coverage Diff @@
## master #1546 +/- ##
==========================================
- Coverage 89.37% 89.37% -0.01%
==========================================
Files 353 353
Lines 17316 17314 -2
==========================================
- Hits 15476 15474 -2
Misses 1377 1377
Partials 463 463
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
unspasadsa
branch
from
de3644a to
414cf2b
Compare
jpkrohling
approved these changes
Nov 10, 2020
dyladan
referenced
this pull request
in dynatrace-oss-contrib/opentelemetry-collector-contrib
Jan 29, 2021
* fix go generate go generate would not work because a tool (esc) was missing from install-tools. fixing in preparation for metrics metadata generation. * Metric metadata generation This implements the proposal (phase 1) in #985. Currently just the cpu scraper has been migrated to gather feedback before moving additional ones. The plan is to check in the generated_metrics.go files. This makes it easier when others want to import the code as a library to not have to run the code generation in a library dependency. generated_metrics.go will be generated by running `go generate`. Resolves #985 * metadata improvements * acronyms (e.g. CpuState) are now formatted correctly (CPUState) * now handles labels with different semantics (e.g. state label in memory vs cpu) * they are referenced in code by unique ids (CPUState, MemState) but their string values are just "state" * specify which labels are referenced by a given metric * adding tests * merge cleanup * cleanup * cleanup * don't do codegen on windows for now * fix lint issues * fix coverage checks * fix ignore * add docs, code review feedback * invalid metric type check * update docs * cleanup * doc fix * make system.memory.usage int sum * move golint code to third_party dir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com