Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/ottl] Add resource context #14887

Merged
merged 4 commits into from
Oct 12, 2022

Conversation

TylerHelmuth
Copy link
Member

Description:
Adds a new context specific to resources to allow for specific and efficient access to resource telemetry.

I specifically did not remove the ability for "lower" telemetry contexts to access the resource with which they are associated. It is important that when processing a span/logrecord/datapoint that the user have access to the resource in case they need it for a condition or something else.

Link to tracking Issue:
#14578

Testing:
Added unit tests

Documentation:
Added context documentation

Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

pkg/ottl/contexts/ottlresource/README.md Outdated Show resolved Hide resolved
Co-authored-by: Evan Bradley <github@evanbradley.org>
@bogdandrutu bogdandrutu merged commit a954add into open-telemetry:main Oct 12, 2022
@TylerHelmuth TylerHelmuth deleted the ottl-resource-context branch October 12, 2022 17:16
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
* Add resource context

* Add changelog entry

* Fix lint

* Update pkg/ottl/contexts/ottlresource/README.md

Co-authored-by: Evan Bradley <github@evanbradley.org>

Co-authored-by: Evan Bradley <github@evanbradley.org>
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants