Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/snmp] Adds client for SNMP metric receiver #14794

Merged
merged 2 commits into from
Oct 10, 2022
Merged

[receiver/snmp] Adds client for SNMP metric receiver #14794

merged 2 commits into from
Oct 10, 2022

Conversation

StefanKurek
Copy link
Contributor

Description:
Adds a client for the SNMP metric receiver. The client has two main methods:
GetScalarData which will take a list of scalar OIDs and a process function which will be run against each piece of retrieved data.
GetIndexedData which will take a list of column OIDs and a process function which will be run against each piece of retrieved data.

Link to tracking Issue:
#13409

Testing:
Added unit tests for client.

Documentation:
No new documentation needed

receiver/snmpreceiver/client.go Outdated Show resolved Hide resolved
receiver/snmpreceiver/client.go Outdated Show resolved Hide resolved
receiver/snmpreceiver/client.go Outdated Show resolved Hide resolved
receiver/snmpreceiver/client.go Outdated Show resolved Hide resolved
receiver/snmpreceiver/client.go Outdated Show resolved Hide resolved
receiver/snmpreceiver/client.go Outdated Show resolved Hide resolved
receiver/snmpreceiver/client.go Outdated Show resolved Hide resolved
receiver/snmpreceiver/client.go Outdated Show resolved Hide resolved
receiver/snmpreceiver/client.go Show resolved Hide resolved
receiver/snmpreceiver/client.go Show resolved Hide resolved
Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djaglowski djaglowski merged commit 48316af into open-telemetry:main Oct 10, 2022
@StefanKurek StefanKurek deleted the snmp-add-client branch October 10, 2022 21:23
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants