Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/mongodbatlas]: Retain actual raw log line as Body #14388

Merged
merged 1 commit into from
Sep 21, 2022
Merged

[receiver/mongodbatlas]: Retain actual raw log line as Body #14388

merged 1 commit into from
Sep 21, 2022

Conversation

BinaryFissionGames
Copy link
Contributor

@BinaryFissionGames BinaryFissionGames commented Sep 21, 2022 •
edited
Loading

Description:

  • Retain the actual raw, original log line as the Body, instead of reconstructing it and saving it as an attribute and on Body.
  • Remove raw attribute on log

Link to tracking Issue: Resolves #14178

Testing:

  • Updated existing unit tests for log decoding and pdata conversion
  • Manually tested on 4.2 and 5.0 clusters

@BinaryFissionGames BinaryFissionGames marked this pull request as ready for review September 21, 2022 18:16
@BinaryFissionGames BinaryFissionGames requested review from a team and bogdandrutu September 21, 2022 18:16
@djaglowski djaglowski merged commit 5da6313 into open-telemetry:main Sep 21, 2022
@BinaryFissionGames BinaryFissionGames deleted the mongodb-atlas-actual-raw-logs branch September 21, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djaglowski djaglowski djaglowski approved these changes

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu

Assignees

@bogdandrutu bogdandrutu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[receiver/mongodbatlas] Raw log message is not the actual raw log message for JSON logs
3 participants
@BinaryFissionGames @djaglowski @bogdandrutu