-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
s3mapprovider for Collector: load configuration from config files in Amazon S3 #14317
Conversation
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I will merge once the CI passes. Thanks @rice-junhaoyu for taking the time to open this new PR and address the required changes :)
Is this implementation operational in v0.76.0? I'm getting the following:
|
This comment was marked as outdated.
This comment was marked as outdated.
Apologies >< |
This is not available in the collector-contrib distribution as the collector builder does not yet have support for specifying which config providers to include. See open-telemetry/opentelemetry-collector#4759. |
@Aneurysm9 oh thank you for that clarification! It's not clear from the docs that that was the case! |
Description:
An implementation of ConfigMapProvider for Amazon S3 (s3mapprovider) allows OTEL Collector the ability to load configuration for itself by fetching and reading config files stored in Amazon S3.
This PR is the same PR as #13113, but requires me to open a new one due to my deactivated email address. It was already reviewed by @mx-psi and @Aneurysm9.
Link to tracking Issue:
#12939
Testing:
First, I mocked how a S3 client works while interacting with a S3 server.
Second, I designed and passed all the unit tests for edge cases such as empty fields, invalid config files, non-exist config files and so on.
Third, I did integration tests such as:
Documentation:
Added a README.md
Sponsor:
@Aneurysm9