[pkg/translator/loki] Split conversion logic into a package #14106
Conversation
jpkrohling
force-pushed
the
jpkrohling/issue13649
branch
from
f899dc6 to
7a5510f
Compare
jpkrohling
force-pushed
the
jpkrohling/issue13649
branch
2 times, most recently
from
d18659a to
4675174
Compare
|
@kovrus, I'm still unsure if we should consume the logproto directly from Loki or if we should just copy it here. If we just copy, we probably won't be able to use this translator directly on Loki, as the proto would cause a duplicate registration on their side. @cyriltovena and @owen-d, I would love to hear your opinions as well. |
|
I'll rebase this after the release, but I consider this PR ready to be reviewed. |
pkg/translator/loki/logs_to_loki.go
Outdated
| "go.uber.org/zap" | ||
| ) | ||
|
|
||
| func LogsToLoki(logger *zap.Logger, ld plog.Logs) (pr *logproto.PushRequest) { |
There was a problem hiding this comment.
Having zap.Logger as a parameter of this method would enforce users of pkg/translator/loki to use go.uber.org/zap. I am wondering whether we can remove this logger method parameter and make this method return an error as well. Then we can drop the go.uber.org/zap dep of this package altogether, since it is not used anywhere else. Alternatively, we can add some generic logger wrapper, but it seems like an overkill.
There was a problem hiding this comment.
Removing would make sense, I believe
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
jpkrohling
force-pushed
the
jpkrohling/issue13649
branch
from
43fa8d6 to
9fba9ad
Compare
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
|
@jpkrohling Is this meant to be consumed outside of the contrib repository? (The description makes me think it is, but I want to make sure just in case we can make this |
|
@mx-psi, yes, I intend to use this on a PR I'm about to start working on for Loki, to add an OTLP endpoint there. |
|
|
||
| // some dependencies attempt to bring something like v1.8.2-0.20220303173753-edfe657b5405, which is older than v0.38.0 | ||
| // at the time of this inclusion, v0.38.0 was the latest version available (also tagged as v2.38.0) | ||
| replace github.com/prometheus/prometheus => github.com/prometheus/prometheus v0.38.0 |
There was a problem hiding this comment.
We should add this replace to the contrib distro file on opentelemetry-collector-releases
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
|
Documented! In the process of documenting, I realized that I might need different functions for the OTLP endpoint I'll build, but I'll send smaller PRs if that's the case. |
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
…emetry#14106) As a second step of the Loki exporter refactoring, this change splits the conversion logic into its own package, so that it can be consumed by Loki itself in the future.
|
Closes #13649 |
As a second step of the Loki exporter refactoring, this change splits the conversion logic into its own package, so that it can be consumed by Loki itself in the future.
Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de