Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/awsemfexporter] Fix: support empty dimension set in dimensions of metric definitions in the awsemfexporter #13766

Merged
merged 4 commits into from
Sep 2, 2022
Merged

[exporter/awsemfexporter] Fix: support empty dimension set in dimensions of metric definitions in the awsemfexporter #13766

merged 4 commits into from
Sep 2, 2022

Conversation

rapphil
Copy link
Contributor

@rapphil rapphil commented Aug 31, 2022 •
edited
Loading

Description:

Add support to empty dimension set in metric_definitions dimensions. The current behavior, which is wrong, is to ignore empty dimension sets and later drop metric groups with empty dimensions.

Link to tracking Issue: #4739 and aws-observability/aws-otel-collector#1013

Testing:

  • Updated and added UTs demonstrating the feature/fix.
  • Tested locally using a prometheus node exporter and the prometheus receiver.

Documentation:

  • Updated documentation describing the behavior and added example of usage.

@rapphil rapphil requested a review from a team August 31, 2022 23:50
@rapphil rapphil mentioned this pull request Aug 31, 2022
Closed
@rapphil rapphil changed the title Add support to empty dimension set in dimensions of metric definitions in the awsemfexporter Fix: support to empty dimension set in dimensions of metric definitions in the awsemfexporter Sep 1, 2022
@rapphil rapphil changed the title Fix: support to empty dimension set in dimensions of metric definitions in the awsemfexporter Fix: support empty dimension set in dimensions of metric definitions in the awsemfexporter Sep 1, 2022
@rapphil rapphil changed the title Fix: support empty dimension set in dimensions of metric definitions in the awsemfexporter [awsemfexporter] Fix: support empty dimension set in dimensions of metric definitions in the awsemfexporter Sep 1, 2022
@rapphil rapphil requested review from Aneurysm9 and bogdandrutu and removed request for Aneurysm9 and bogdandrutu September 1, 2022 16:35
Aneurysm9
Aneurysm9 approved these changes Sep 1, 2022
View reviewed changes
unreleased/awsemfexporter-fix-4739.yaml Outdated Show resolved Hide resolved
@rapphil rapphil changed the title [awsemfexporter] Fix: support empty dimension set in dimensions of metric definitions in the awsemfexporter [exporter/awsemfexporter] Fix: support empty dimension set in dimensions of metric definitions in the awsemfexporter Sep 1, 2022
@bogdandrutu bogdandrutu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 2, 2022
@bogdandrutu bogdandrutu merged commit 419bd3a into open-telemetry:main Sep 2, 2022
@rapphil rapphil mentioned this pull request Apr 26, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

Assignees

@mx-psi mx-psi

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rapphil @Aneurysm9 @bogdandrutu @mx-psi