-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/AlibabaCloudLogServiceExporter] Fix issue that promethus occuring error when resource labels contains dot #13393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pinging @shabicheng @kongluoxing as code owners |
shabicheng
approved these changes
Aug 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
qiansheng91
changed the title
[exporter/AlibabaCloudLogServiceExporter] Fix issue that promethus occuring error when resource contains labels dot
[exporter/AlibabaCloudLogServiceExporter] Fix issue that promethus occuring error when resource labels contains dot
Aug 18, 2022
…y-collector-contrib into sanitize-metric
qiansheng91
requested review from
shabicheng
and removed request for
jpkrohling
August 18, 2022 02:10
TylerHelmuth
approved these changes
Aug 18, 2022
How soon will this PR be merged? |
I'll merge this once the CI is green. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As issue #3429 mentioned, PR #3454 missed sanitizing the resource metric labels. The Prometheus still occurring issue when the resource metrics label contains a dot.
How to fix
Just sanitize those labels when appending resource labels.
PR #3454 has already added sanitize logical in the
KeyValues.Append
Method. Just like this. So the sanitize logically will be active when the resource metric labels call theAppend
method.