[exporter/signalfx] reduce log level of attempts to divide by zero #12970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmcollins
changed the title
dloucasfx
suggested changes
Aug 5, 2022
dmitryax
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Attempts to divide by zero when executing sfx translation rules are currently logged as warnings. This has caused some users to report lots of noise in logs. However, encountering a denominator that, as a result of a calculation, computes to zero, doesn't necessarily indicate a problem. As a result, this change decreases the log level to
debugfor this message.Link to tracking Issue: #12969
Testing: Testing was performed locally using simulated data.