Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[internal/coreinternal/processor/filtermatcher]Enable gocritic #12636

Merged
merged 1 commit into from
Jul 22, 2022
Merged

[internal/coreinternal/processor/filtermatcher]Enable gocritic #12636

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions internal/coreinternal/processor/filtermatcher/attributematcher.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

// nolint:gocritic
package filtermatcher // import "github.com/open-telemetry/opentelemetry-collector-contrib/internal/coreinternal/processor/filtermatcher"

import (
Expand Down Expand Up @@ -58,7 +57,8 @@ func NewAttributesMatcher(config filterset.Config, attributes []filterconfig.Att
return nil, err
}

if config.MatchType == filterset.Regexp {
switch config.MatchType {
case filterset.Regexp:
if val.Type() != pcommon.ValueTypeString {
return nil, fmt.Errorf(
"%s=%s for %q only supports STRING, but found %s",
Expand All @@ -71,10 +71,11 @@ func NewAttributesMatcher(config filterset.Config, attributes []filterconfig.Att
return nil, err
}
entry.StringFilter = filter
} else if config.MatchType == filterset.Strict {
case filterset.Strict:
entry.AttributeValue = &val
} else {
default:
return nil, filterset.NewUnrecognizedMatchTypeError(config.MatchType)

}
}

Expand Down