Increase timeout for integration tests #12203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently introduced `TestOracleDBIntegration` integration test runs just on the edge on 5 minutes. This change increases the timeout to give it enough time to pass.
| @@ -4,7 +4,7 @@ SRC_ROOT := $(realpath $(dir $(lastword $(MAKEFILE_LIST)))) | |||
| # build tags required by any component should be defined as an independent variables and later added to GO_BUILD_TAGS below | |||
| GO_BUILD_TAGS="" | |||
| GOTEST_OPT?= -race -v -timeout 300s --tags=$(GO_BUILD_TAGS) | |||
| GOTEST_INTEGRATION_OPT?= -race -timeout 300s | |||
| GOTEST_INTEGRATION_OPT?= -race -timeout 360s | |||
There was a problem hiding this comment.
I worry that increasing this would just encourage others to keep extending what their system does for timeouts.
Is there a way we can add in the ability for a virtual clock or something of that effect if we are testing time based functionality?
There was a problem hiding this comment.
I see what you're saying but I'm less worried about this than I am with CI stability. Please open an issue with a proposal if you have an idea how this could be implemented.
djaglowski
approved these changes
Jul 11, 2022
| @@ -4,7 +4,7 @@ SRC_ROOT := $(realpath $(dir $(lastword $(MAKEFILE_LIST)))) | |||
| # build tags required by any component should be defined as an independent variables and later added to GO_BUILD_TAGS below | |||
| GO_BUILD_TAGS="" | |||
| GOTEST_OPT?= -race -v -timeout 300s --tags=$(GO_BUILD_TAGS) | |||
| GOTEST_INTEGRATION_OPT?= -race -timeout 300s | |||
| GOTEST_INTEGRATION_OPT?= -race -timeout 360s | |||
There was a problem hiding this comment.
I see what you're saying but I'm less worried about this than I am with CI stability. Please open an issue with a proposal if you have an idea how this could be implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently introduced
TestOracleDBIntegrationintegration test runs just on the edge on 5 minutes. This change increases the timeout to give it enough time to pass.Fixes #12202