-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/datadog] Add Kubernetes hostname provider #10911
[exporter/datadog] Add Kubernetes hostname provider #10911
Conversation
6743844
to
19fe8ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use resource detectors, and then reference resource attributes in this exporter? It seems like this is reimplementing most resource detection code.
@dashpole That's a fair question. We have tried to rely as much as possible on the resource detection processor/k8sattributes processor so far (e.g. our current implementation requires you to use the k8sattributes processor if on Kubernetes for certain environments), but with this approach it's not possible to support some setups without passing significant complexity to users. Our exporter needs to send a payload with information about the 'host' in which it is running, but when information like That said, I am trying to not duplicate code (see #10376) and will do future refactors to reduce code duplication more, so that in that sense the duplication is reduced as much as possible. |
We can't make it fail at provider build time, since otherwise it will make the whole provider build fail if we are not on Kubernetes
Description:
Link to tracking Issue: #10424
Testing: Added unit tests. TBD: end to end tests