first enable gocritic and exclude all components that are not passing… #10422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatsheep9146
requested review from
jmacd,
dmitryax,
pmm-sumo,
djaglowski,
Aneurysm9,
dashpole,
bogdandrutu,
TylerHelmuth,
jpkrohling,
punya,
arminru,
mx-psi and
alolita
as code owners
… right now. Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
fatsheep9146
force-pushed
the
gocritic-linter
branch
from
5865cbb
to
8429d49
Compare
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
mx-psi
reviewed
May 30, 2022
mx-psi
approved these changes
May 31, 2022
|
@codeboten could you merge this? |
TylerHelmuth
reviewed
Jun 1, 2022
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package ecsinfo // import "github.com/open-telemetry/opentelemetry-collector-contrib/receiver/awscontainerinsightreceiver/internal/ecsInfo" |
There was a problem hiding this comment.
Does this package need the nolint ?
There was a problem hiding this comment.
I try to use nolint at first, but it failed to escape these comments. So I have to correct those comments directly without using nolint.
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package ecsinfo |
There was a problem hiding this comment.
Same reason as the ecsinfo.go
djaglowski
approved these changes
Jun 1, 2022
|
Updated list on #10466 with the files changed on this PR |
kentquirk
pushed a commit
to McSick/opentelemetry-collector-contrib
that referenced
this pull request
Jun 14, 2022
open-telemetry#10422) * first enable gocritic and exclude all components that are not passing right now. Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com> * gofmt error Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix #10465 as @mx-psi suggested, first enable
gocriticand exclude all components that are not passing right now.Link to tracking Issue:
#10465
Signed-off-by: Ziqi Zhao zhaoziqi9146@gmail.com