Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update core dependency #1037

Merged
merged 1 commit into from
Sep 15, 2020
Merged

Conversation

bogdandrutu
Copy link
Member

Update processors to use the new signature for trace and metrics

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu requested a review from a team September 15, 2020 19:59
@codecov
Copy link

codecov bot commented Sep 15, 2020

Codecov Report

Merging #1037 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1037   +/-   ##
=======================================
  Coverage   88.74%   88.74%           
=======================================
  Files         249      249           
  Lines       13297    13297           
=======================================
  Hits        11801    11801           
  Misses       1141     1141           
  Partials      355      355           
Flag Coverage Δ
#integration 74.88% <ø> (ø)
#unit 87.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6502987...19a80ef. Read the comment docs.

@tigrannajaryan tigrannajaryan merged commit 3159005 into open-telemetry:master Sep 15, 2020
@bogdandrutu bogdandrutu deleted the fuxmore branch September 15, 2020 20:52
dyladan referenced this pull request in dynatrace-oss-contrib/opentelemetry-collector-contrib Jan 29, 2021
* Generate OTLP Go code in this repo

Generate ProtoBufs in this repository instead of importing from opentelemetry-proto.
This allows us to customize the generation process.

- Added opentelemetry-proto as a submodule.
- Added `make genproto` target that generates Go ProtoBufs from opentelemetry-proto
  submodule and puts them in internal/opentelemetry-proto-gen.
  Generation is done using Gogoproto instead of Go Protobuf.
- Modified all files to import OTLP Go code from internal/opentelemetry-proto-gen.

* Add wire compatibility tests
ljmsc referenced this pull request in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
* Fix instrumentation lib version in spanDataToThrift

* Update CHANGELOG.md

* Use test value for lib version in accordance with the spec

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants