Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus compliance tests fail due to removed flag #7380

Closed
gouthamve opened this issue Jan 25, 2022 · 2 comments · Fixed by #7391
Closed

Prometheus compliance tests fail due to removed flag #7380

gouthamve opened this issue Jan 25, 2022 · 2 comments · Fixed by #7391
Assignees
@gouthamve
Labels
bug Something isn't working

Comments

@gouthamve
Copy link
Member

Describe the bug

In recent PRs, the Prometheus compliance tests fail. The compliance suite runs with a flag --metrics-addr=:0 which has been removed in this commit: 21273c6 (found via git bisect).

Error: unknown flag: --metrics-addr
2022/01/25 15:13:48 collector server run finished with error: unknown flag: --metrics-addr

Trying to see if this was intentional or not. If not, I'll update the compliance repo to not set that flag.
@gouthamve gouthamve added the bug Something isn't working label Jan 25, 2022
@gouthamve gouthamve mentioned this issue Jan 25, 2022
Merged
@jpkrohling
Copy link
Member

jpkrohling commented Jan 25, 2022 •
edited
Loading

The removal was intentional, replaced by an entry in the config file under service::telemetry::metrics.

service:
  telemetry:
    metrics:
      address: ":0"

gouthamve added a commit to gouthamve/compliance that referenced this issue Jan 25, 2022
@gouthamve
Update version of OTel Collector
0fe0885 
See: open-telemetry/opentelemetry-collector-contrib#7380

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
@gouthamve gouthamve mentioned this issue Jan 25, 2022
Closed
@gouthamve
Copy link
Member Author

Once this is merged: prometheus/compliance#67 I'll update our CI to use the new version

gouthamve added a commit to gouthamve/compliance that referenced this issue Jan 25, 2022
@gouthamve
Update version of OTel Collector
a0b8338 
See: open-telemetry/opentelemetry-collector-contrib#7380

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
gouthamve added a commit to gouthamve/compliance that referenced this issue Jan 26, 2022
@gouthamve
Update version of OTel Collector
af990fb 
See: open-telemetry/opentelemetry-collector-contrib#7380

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
@gouthamve gouthamve mentioned this issue Jan 26, 2022
Merged
@gouthamve gouthamve mentioned this issue Jun 21, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gouthamve gouthamve

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Prometheus compliance tests gouthamve/opentelemetry-collector-contrib
2 participants
@jpkrohling @gouthamve