Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[extension/opampextension] Report os.description semantic convention #35555

Closed
dpaasman00 opened this issue Oct 2, 2024 · 2 comments · Fixed by #35816
Closed

[extension/opampextension] Report os.description semantic convention #35555

dpaasman00 opened this issue Oct 2, 2024 · 2 comments · Fixed by #35816
Labels
enhancement New feature or request extension/opamp

Comments

@dpaasman00
Copy link
Contributor

Component(s)

No response

Is your feature request related to a problem? Please describe.

I'd like to communicate the exact operating system and version my collector is running on over OpAMP. Currently the extension only reports the OS and arch which doesn't tell me the version of the OS.

Describe the solution you'd like

I'd like to add the semantic convention os.description as a non-identifying attribute in the agent description message sent by the extension.

Describe alternatives you've considered

No response

Additional context

The semantic convention definition for os.description can be found here. Additionally I'd like to take on contributing this enhancement.
@dpaasman00 dpaasman00 added enhancement New feature or request needs triage New item requiring triage labels Oct 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@crobert-1
Copy link
Member

Removing needs triage as a code owner has responded 👍 to this issue.

@crobert-1 crobert-1 removed the needs triage New item requiring triage label Oct 2, 2024
@dpaasman00 dpaasman00 mentioned this issue Oct 4, 2024
Closed
@github-actions github-actions bot mentioned this issue Oct 8, 2024
Closed
@dpaasman00 dpaasman00 mentioned this issue Oct 15, 2024
Merged
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this issue Dec 17, 2024
@dpaasman00 @sbylica-splunk
[extension/opamp] Add os.description as non-identifying agent attri…
eb9df65 
…bute (open-telemetry#35816)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

The opamp extension now reports additional information about the host
machine's operating system, specifically the version. It does so by
reporting the semantic convention `os.description`(defined
[here](https://opentelemetry.io/docs/specs/semconv/attributes-registry/os/))
as a non-identifying attribute in the agent description message.

**Link to tracking Issue:** <Issue number if applicable> Closes open-telemetry#35555

**Testing:** <Describe what testing was performed and which tests were
added.> Unit tests updated.
Verified `os.description` attribute shows up with values like 'macOS
15.0' and 'Ubuntu 20.04.6 LTS'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request extension/opamp
Projects
None yet
Milestone
No milestone
2 participants
@crobert-1 @dpaasman00