Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pkg/ottl] Create e2e XML benchmarks #35471

Closed
djaglowski opened this issue Sep 27, 2024 · 1 comment · Fixed by #35493
Closed

[pkg/ottl] Create e2e XML benchmarks #35471

djaglowski opened this issue Sep 27, 2024 · 1 comment · Fixed by #35493
Assignees
@djaglowski
Labels
pkg/ottl

Comments

@djaglowski
Copy link
Member

Can we add some xml "e2e" benchmarks? Something that benchmarks a reasonable use of the xml functions so we can see what users will experience?

Originally posted by @TylerHelmuth in #35281 (comment)
@djaglowski djaglowski self-assigned this Sep 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

This was referenced Sep 27, 2024
Closed
Merged
@github-actions github-actions bot mentioned this issue Oct 1, 2024
Closed
djaglowski added a commit that referenced this issue Oct 1, 2024
@djaglowski
[chore] Add benchmark for new XML crud functions (#35493)
2797fa0 
The benchmark performs a round trip of operations, getting values from
the document, inserting them elsewhere, then removing them, and
ultimately overwriting the original value with the "new" (same) value.

Resolves #35471
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this issue Oct 4, 2024
@djaglowski @jriguera
[chore] Add benchmark for new XML crud functions (open-telemetry#35493)
6432cb0 
The benchmark performs a round trip of operations, getting values from
the document, inserting them elsewhere, then removing them, and
ultimately overwriting the original value with the "new" (same) value.

Resolves open-telemetry#35471
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djaglowski djaglowski

Labels
pkg/ottl
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[chore] Add benchmark for new XML crud functions djaglowski/opentelemetry-collector-contrib
1 participant
@djaglowski