Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmd/opampsupervisor] Add configurable supervisor logging #35466

Closed
dpaasman00 opened this issue Sep 27, 2024 · 1 comment · Fixed by #35468
Closed

[cmd/opampsupervisor] Add configurable supervisor logging #35466

dpaasman00 opened this issue Sep 27, 2024 · 1 comment · Fixed by #35468
Assignees
@dpaasman00
Labels
cmd/opampsupervisor enhancement New feature or request

Comments

@dpaasman00
Copy link
Contributor

Component(s)

cmd/opampsupervisor

Is your feature request related to a problem? Please describe.

Right now the supervisor strictly logs to stdout which can be a pain point when trying to monitor the supervisor's logs.

Describe the solution you'd like

Add the option to configure how the supervisor logs data like log level and output destinations.

Describe alternatives you've considered

You could just pipe the process output to a file, but that seems tedious. That approach also doesn't allow configuring log level output or other helpful logging configuration options.

Additional context

I have a solution in progress for this feature request.
@dpaasman00 dpaasman00 added enhancement New feature or request needs triage New item requiring triage labels Sep 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

This was referenced Sep 27, 2024
Merged
Closed
@github-actions github-actions bot mentioned this issue Oct 1, 2024
Closed
@evan-bradley evan-bradley removed the needs triage New item requiring triage label Oct 2, 2024
evan-bradley pushed a commit that referenced this issue Oct 3, 2024
@dpaasman00
[cmd/opampsupervisor] Add configurable supervisor logging (#35468)
6945c86 
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

Adds configurable logging for the supervisor. Lays ground work to expand
with more config options and to configure other telemetry signals. Meant
to mimic how collector telemetry/logging is configured.

**Link to tracking Issue:** <Issue number if applicable> Closes #35466 

**Testing:** <Describe what testing was performed and which tests were
added.>
Tested running the supervisor with default and different log levels and
outputs specified.

**Documentation:** <Describe the documentation added.>
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this issue Oct 4, 2024
@dpaasman00 @jriguera
[cmd/opampsupervisor] Add configurable supervisor logging (open-telem…
265b616 
…etry#35468)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

Adds configurable logging for the supervisor. Lays ground work to expand
with more config options and to configure other telemetry signals. Meant
to mimic how collector telemetry/logging is configured.

**Link to tracking Issue:** <Issue number if applicable> Closes open-telemetry#35466 

**Testing:** <Describe what testing was performed and which tests were
added.>
Tested running the supervisor with default and different log levels and
outputs specified.

**Documentation:** <Describe the documentation added.>
ghost pushed a commit to sematext/opentelemetry-collector-contrib that referenced this issue Oct 9, 2024
@dpaasman00 @AkhigbeEromo
[cmd/opampsupervisor] Add configurable supervisor logging (open-telem…
51f4cfd 
…etry#35468)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

Adds configurable logging for the supervisor. Lays ground work to expand
with more config options and to configure other telemetry signals. Meant
to mimic how collector telemetry/logging is configured.

**Link to tracking Issue:** <Issue number if applicable> Closes open-telemetry#35466 

**Testing:** <Describe what testing was performed and which tests were
added.>
Tested running the supervisor with default and different log levels and
outputs specified.

**Documentation:** <Describe the documentation added.>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dpaasman00 dpaasman00

Labels
cmd/opampsupervisor enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[cmd/opampsupervisor] Add configurable supervisor logging observIQ/opentelemetry-collector-contrib
2 participants
@evan-bradley @dpaasman00