Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datadog receiver is missing container id #35345

Closed
povilasv opened this issue Sep 23, 2024 · 1 comment
Closed

datadog receiver is missing container id #35345

povilasv opened this issue Sep 23, 2024 · 1 comment
Labels
enhancement New feature or request needs triage New item requiring triage receiver/datadog

Comments

@povilasv
Copy link
Contributor

Component(s)

receiver/datadog

Is your feature request related to a problem? Please describe.

Looks like we are missing container id in DD receiver, and this makes some screens in DD don't work (when received and exported thru collector)

Describe the solution you'd like

I've got details of some request:

Sending request: PUT v0.5/traces {'Datadog-Meta-Lang': 'python', 'Datadog-Meta-Lang-Version': '3.10.14', 'Datadog-Meta-Lang-Interpreter': 'CPython', 'Datadog-Meta-Tracer-Version': '2.7.2', 'Datadog-Client-Computed-Top-Level': 'yes', 'Datadog-Container-Id': '7d0f62eb396bd016230ebc53d525bd6bc9ce734894fcf70b39f268b62001a79d', 'Datadog-Entity-ID': 'cid-7d0f62eb396bd016230ebc53d525bd6bc9ce734894fcf70b39f268b62001a79d', 'Content-Type': 'application/msgpack', 'X-Datadog-Trace-Count': '1'}

Looks like Datadog-Container-Id is the header. I've looked thru exporter code and it should pick up container id from semconv, so in theory should work.

Describe alternatives you've considered

No response

Additional context

No response

@povilasv povilasv added enhancement New feature or request needs triage New item requiring triage labels Sep 23, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

MovieStoreGuy pushed a commit that referenced this issue Sep 25, 2024
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
Add parsing of Container ID from DD v0.5 request.

I've got a hold of an example request:
```
Sending request: PUT v0.5/traces {'Datadog-Meta-Lang': 'python', 'Datadog-Meta-Lang-Version': '3.10.14', 'Datadog-Meta-Lang-Interpreter': 'CPython', 'Datadog-Meta-Tracer-Version': '2.7.2', 'Datadog-Client-Computed-Top-Level': 'yes', 'Datadog-Container-Id': '7d0f62eb396bd016230ebc53d525bd6bc9ce734894fcf70b39f268b62001a79d', 'Datadog-Entity-ID': 'cid-7d0f62eb396bd016230ebc53d525bd6bc9ce734894fcf70b39f268b62001a79d', 'Content-Type': 'application/msgpack', 'X-Datadog-Trace-Count': '1'}
```
**Link to tracking Issue:** 


#35345

**Testing:** <Describe what testing was performed and which tests were
added.>
-  updated unit test

**Documentation:** <Describe the documentation added.>
-
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this issue Oct 4, 2024
…metry#35346)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
Add parsing of Container ID from DD v0.5 request.

I've got a hold of an example request:
```
Sending request: PUT v0.5/traces {'Datadog-Meta-Lang': 'python', 'Datadog-Meta-Lang-Version': '3.10.14', 'Datadog-Meta-Lang-Interpreter': 'CPython', 'Datadog-Meta-Tracer-Version': '2.7.2', 'Datadog-Client-Computed-Top-Level': 'yes', 'Datadog-Container-Id': '7d0f62eb396bd016230ebc53d525bd6bc9ce734894fcf70b39f268b62001a79d', 'Datadog-Entity-ID': 'cid-7d0f62eb396bd016230ebc53d525bd6bc9ce734894fcf70b39f268b62001a79d', 'Content-Type': 'application/msgpack', 'X-Datadog-Trace-Count': '1'}
```
**Link to tracking Issue:** 


open-telemetry#35345

**Testing:** <Describe what testing was performed and which tests were
added.>
-  updated unit test

**Documentation:** <Describe the documentation added.>
-
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage New item requiring triage receiver/datadog
Projects
None yet
Development

No branches or pull requests

1 participant