-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubernetes ingresses not being observed by extension #35324
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Hi @stokerjon I also just looked into this and seems you are right - the config for enabling the Ingress observation does not seem to be considered when creating the K8s resource informers - right now, only pods, nodes and services are observed. I'd be happy to work on a PR to fix that |
**Description:** This PR fixes the observation of ingress objects by the k8sobserver. The issue was that the `observe_ingresses` option was not considered in the extension setup, and no informer for the ingress resource type has been created **Link to tracking Issue:** #35324 **Testing:** Added unit tests. Also did manual testing against a k8s cluster to check whether ingress objects are picked up as expected **Documentation:** No change there, as the `observe_ingresses` option was already documented in the readme --------- Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com> Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners: See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This is fixed now, thanks |
Thank's @bacherfl for the fix! |
…ry#35539) **Description:** This PR fixes the observation of ingress objects by the k8sobserver. The issue was that the `observe_ingresses` option was not considered in the extension setup, and no informer for the ingress resource type has been created **Link to tracking Issue:** open-telemetry#35324 **Testing:** Added unit tests. Also did manual testing against a k8s cluster to check whether ingress objects are picked up as expected **Documentation:** No change there, as the `observe_ingresses` option was already documented in the readme --------- Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com> Co-authored-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Component(s)
extension/observer/k8sobserver
What happened?
Description
When using k8s_observer with receiver creator and setting
observe_ingresses: true
it would be expected that it would start to create recievers based off of ingresses available in the cluster.having a quick look it looks like the code to enable observing ingresess is missing from extension/observer/k8sobserver/extension.go
Steps to Reproduce
create a colloctor with the provided config
Expected Result
receiver creator would create receivers for ingresses in the cluster
Actual Result
ingresses are not observed and receiver creator does nothing
Collector version
v1.15.0/v0.109.0
Environment information
Environment
OS: amazon linux
kubernetes: v1.30
OpenTelemetry Collector configuration
Log output
Additional context
No response
The text was updated successfully, but these errors were encountered: