Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Headers Setter extension context default value configurable #35151

Closed
kyo-ke opened this issue Sep 12, 2024 · 4 comments
Closed

Make Headers Setter extension context default value configurable #35151

kyo-ke opened this issue Sep 12, 2024 · 4 comments
Labels
enhancement New feature or request extension/headerssetter needs triage New item requiring triage

Comments

@kyo-ke
Copy link

kyo-ke commented Sep 12, 2024

Component(s)

No response

Is your feature request related to a problem? Please describe.

We are pushing traces to Tempo via opentelemetry collector.
when we push trace to multitenant Tempo we need to handle X-Scope-OrgID header using Headers Setter extension.
in current version if user do not specify X-Scope-OrgID this extension automatically use "" as value.(Default value is hardcoded)
and sometimes we want to use specific tenant to store user's trace with no X-Scope-OrgID

problem is we cannot configure default value when specified key is missing.
(https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/extension/headerssetterextension/internal/source/context.go#L24)

Describe the solution you'd like

Make default value configurable for Headers Setter extension's context functionality.
we will create PR for this.

Describe alternatives you've considered

No response

Additional context

No response

@kyo-ke kyo-ke added enhancement New feature or request needs triage New item requiring triage labels Sep 12, 2024
kyo-ke added a commit to kyo-ke/opentelemetry-collector-contrib that referenced this issue Sep 12, 2024
kyo-ke added a commit to kyo-ke/opentelemetry-collector-contrib that referenced this issue Sep 12, 2024
@crobert-1
Copy link
Member

Hello @kyo-ke, thanks for filing this issue! Is this the same problem as reported in #34412? If so, it would be preferable to only have one issue open for a given issue, but let me know if I'm missing something here 👍

Copy link
Contributor

Pinging code owners for extension/headerssetter: @jpkrohling. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@kyo-ke
Copy link
Author

kyo-ke commented Sep 13, 2024

Hello @crobert-1
Thank you for quick response!
yes this is same with #34412.
will close this issue.
I created PR for this. Is it ok to keep my PR open with changing issue number in changelog?

@crobert-1
Copy link
Member

Thanks @kyo-ke!

Closing in favor of #34412

@crobert-1 crobert-1 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request extension/headerssetter needs triage New item requiring triage
Projects
None yet
2 participants