Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide string representation for Span Status field #34590

Open
awangc opened this issue Aug 9, 2024 · 4 comments
Open

Provide string representation for Span Status field #34590

awangc opened this issue Aug 9, 2024 · 4 comments
Labels
enhancement New feature or request exporter/elasticsearch Stale

Comments

@awangc
Copy link

awangc commented Aug 9, 2024

Component(s)

exporter/elasticsearch

Describe the issue you're reporting

Currently in encoding a span, for Span Kind the exporter is adopting a string representation, but the Span Status adopts an integer representation (https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/exporter/elasticsearchexporter/model.go#L396-L397). It'd be great if we could adopt string representation for both, as it is more descriptive of the status.
@awangc awangc added the needs triage New item requiring triage label Aug 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 9, 2024

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@carsonip
Copy link
Contributor

This is the plan for OTel mapping mode as implemented in WIP PR: #34472

This was referenced Aug 12, 2024
Closed
Merged
@crobert-1 crobert-1 added the enhancement New feature or request label Aug 12, 2024
@crobert-1
Copy link
Member

Removing needs triage based on response from code owner.

@crobert-1 crobert-1 removed the needs triage New item requiring triage label Aug 12, 2024
@github-actions github-actions bot mentioned this issue Aug 13, 2024
Closed
andrzej-stencel pushed a commit that referenced this issue Aug 23, 2024
@carsonip
[exporter/elasticsearch] Add OTel mapping mode for traces (#34472)
f0d7e7f 
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
Add OTel mapping mode for traces.

OTel mapping mode is a new mapping mode described in
https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/exporter/elasticsearchexporter#elasticsearch-document-mapping

Update logs and metrics OTel mapping mode to always emit "scope" and
zero int, but not emit empty strings for known fields.

Breaking change to remove `trace_flags` from logs.

**Link to tracking Issue:** <Issue number if applicable>
Fixes #34588 #34590 

**Testing:** <Describe what testing was performed and which tests were
added.>
Added exporter tests

**Documentation:** <Describe the documentation added.>
f7o pushed a commit to f7o/opentelemetry-collector-contrib that referenced this issue Sep 12, 2024
@carsonip @f7o
[exporter/elasticsearch] Add OTel mapping mode for traces (open-telem…
ac3e6ff 
…etry#34472)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
Add OTel mapping mode for traces.

OTel mapping mode is a new mapping mode described in
https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/exporter/elasticsearchexporter#elasticsearch-document-mapping

Update logs and metrics OTel mapping mode to always emit "scope" and
zero int, but not emit empty strings for known fields.

Breaking change to remove `trace_flags` from logs.

**Link to tracking Issue:** <Issue number if applicable>
Fixes open-telemetry#34588 open-telemetry#34590 

**Testing:** <Describe what testing was performed and which tests were
added.>
Added exporter tests

**Documentation:** <Describe the documentation added.>
@github-actions GitHub Actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request exporter/elasticsearch Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@awangc @carsonip @crobert-1