Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/datadog] incorrect service.name transformation #34366

Closed
sudomateo opened this issue Aug 1, 2024 · 1 comment · Fixed by #34420
Closed

[exporter/datadog] incorrect service.name transformation #34366

sudomateo opened this issue Aug 1, 2024 · 1 comment · Fixed by #34420
Labels
bug Something isn't working exporter/datadog Datadog components needs triage New item requiring triage

Comments

@sudomateo
Copy link

Component(s)

exporter/datadog

What happened?

I wrote up everything in DataDog/opentelemetry-mapping-go#356 since that's where the issue actually lies but Datadog Support requested that I open an issue on this repository instead. I'm going out of office starting tomorrow so I wanted to get this in beforehand. I'll come back and transfer the content over nicely to this issue when I'm back.

Collector version

latest

Environment information

N/A

OpenTelemetry Collector configuration

processors:
  transform:
    log_statements:
      - context: log
        statements:
          - set(attributes["service.name"], "sudomateo")
          - set(attributes["ddtags"], "source:sudomateo")

Log output

N/A

Additional context

N/A

@sudomateo sudomateo added bug Something isn't working needs triage New item requiring triage labels Aug 1, 2024
@github-actions github-actions bot added the exporter/datadog Datadog components label Aug 1, 2024
Copy link
Contributor

github-actions bot commented Aug 1, 2024

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@mx-psi mx-psi closed this as completed in ebaf5cc Aug 14, 2024
f7o pushed a commit to f7o/opentelemetry-collector-contrib that referenced this issue Sep 12, 2024
…rter` feature flag to beta (open-telemetry#34420)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
Use Datadog Agent logs pipeline by default for exporting logs to
Datadog. Upgrades `exporter.datadogexporter.UseLogsAgentExporter`
feature flag to beta.

Note: if users have `logs::dump_payloads` enabled in their config after
upgrading, an error will be raised because this config option cannot be
used with the logs agent exporter:
https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/f1aadc6c9c5d117eb61898cd2f1969a279a7f80e/exporter/datadogexporter/config.go#L658

**Link to tracking Issue:** <Issue number if applicable>
Fixes
open-telemetry#34366
and introduces general performance improvements.

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>

---------

Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working exporter/datadog Datadog components needs triage New item requiring triage
Projects
None yet
1 participant