Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azuremonitorreceiver: The authentication should support Managed Identity. #34026

Closed
martinjt opened this issue Jul 10, 2024 · 2 comments
Closed
Labels
enhancement New feature or request needs triage New item requiring triage receiver/azuremonitor

Comments

@martinjt
Copy link
Member

Component(s)

receiver/azuremonitor

Is your feature request related to a problem? Please describe.

Currently, there are only manually set Service Principals and Workload Identity (K8s) supported as valid authentication schemes. Since Managed Identity is a core mechanism inside of Azure, that should be a validation option. This would allow for a more seamless experience in Azure Container Apps.

Describe the solution you'd like

In the config for the component you should be able to add "managed_identity" as a valid option.

Describe alternatives you've considered

Providing static credentials via environment variables is an option, however, it's prone to expiry amongst other security issues.

Additional context

Add an additional function here:

https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/receiver/azuremonitorreceiver/scraper.go#L86

Update credentials logic here:

https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/receiver/azuremonitorreceiver/scraper.go#L179

Update validation here:

https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/receiver/azuremonitorreceiver/config.go#L261

Relevant function from the go lib:

https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/sdk/azidentity#NewManagedIdentityCredential

@martinjt martinjt added enhancement New feature or request needs triage New item requiring triage labels Jul 10, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@martinjt
Copy link
Member Author

Fixed in #33584

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage New item requiring triage receiver/azuremonitor
Projects
None yet
Development

No branches or pull requests

1 participant