Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kafkareceiver] add support for otlp_json which accepts json formated for Otel Collector kafka receiver #33627

Closed
govardhanda-Kore opened this issue Jun 18, 2024 · 5 comments
Labels
enhancement New feature or request needs triage New item requiring triage receiver/kafka Stale

Comments

@govardhanda-Kore
Copy link

govardhanda-Kore commented Jun 18, 2024

Component(s)

receiver/kafka

Is your feature request related to a problem? Please describe.

No

Describe the solution you'd like

add support for otlp_json which accepts json formatted oltp data same as http/json in otel collector (Receiver)

const otelresourcespans = {
"resourceSpans": [
{
"resource": {
"attributes": [
{
key: 'service.name',
value: { stringValue: 'serviceName' }
}
]
},
"scopeSpans": [
{
"scope": {
"name": "my.library",
"version": "1.0.0",
"attributes": [
{
"key": "my.scope.attribute",
"value": {
"stringValue": "some scope attribute"
}
}
]
},
"spans": []
}
]
}
]
};

Describe alternatives you've considered

No response

Additional context

No response

@govardhanda-Kore govardhanda-Kore added enhancement New feature or request needs triage New item requiring triage labels Jun 18, 2024
@govardhanda-Kore govardhanda-Kore changed the title add support for otlp_json which accepts json formated add support for otlp_json which accepts json formated for Otel Collector kafka receiver Jun 18, 2024
@govardhanda-Kore govardhanda-Kore changed the title add support for otlp_json which accepts json formated for Otel Collector kafka receiver [kafkareceiver] add support for otlp_json which accepts json formated for Otel Collector kafka receiver Jun 18, 2024
@frzifus
Copy link
Member

frzifus commented Jun 18, 2024

Is this about the receiver/kafka in the collector or in some sdk?

@govardhanda-Kore
Copy link
Author

hey, thanks your response, yes it's about the receiver/kafka in the collector

Copy link
Contributor

Pinging code owners for receiver/kafka: @pavolloffay @MovieStoreGuy. See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Aug 19, 2024
mx-psi pushed a commit that referenced this issue Sep 16, 2024
)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.

Ex. Adding a feature - Explain what this achieves.-->The current
features dont support otlp_json in receivers/kafkareceivers.
Add support for otlp_json which accepts json formated for Otel Collector
kafka receiver
**Link to tracking Issue:** <Issue number if applicable>  #33627

**Testing:** <Describe what testing was performed and which tests were
added.>
Added test files for the same. 

**Documentation:** <Describe the documentation added.>

---------

Signed-off-by: joeyyy09 <menteharshith@gmail.com>
Co-authored-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
@atoulme
Copy link
Contributor

atoulme commented Oct 2, 2024

Implemented with #34840 closing

@atoulme atoulme closed this as completed Oct 2, 2024
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this issue Oct 4, 2024
…n-telemetry#34840)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.

Ex. Adding a feature - Explain what this achieves.-->The current
features dont support otlp_json in receivers/kafkareceivers.
Add support for otlp_json which accepts json formated for Otel Collector
kafka receiver
**Link to tracking Issue:** <Issue number if applicable>  open-telemetry#33627

**Testing:** <Describe what testing was performed and which tests were
added.>
Added test files for the same. 

**Documentation:** <Describe the documentation added.>

---------

Signed-off-by: joeyyy09 <menteharshith@gmail.com>
Co-authored-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage New item requiring triage receiver/kafka Stale
Projects
None yet
Development

No branches or pull requests

4 participants