Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make update-otel shouldn't update the toolchain #33600

Closed
codeboten opened this issue Jun 17, 2024 · 4 comments · Fixed by #35490
Closed

make update-otel shouldn't update the toolchain #33600

codeboten opened this issue Jun 17, 2024 · 4 comments · Fixed by #35490
Labels
ci-cd CI, CD, testing, build issues good first issue Good for newcomers help wanted Extra attention is needed

Comments

@codeboten
Copy link
Contributor

Component(s)

No response

Describe the issue you're reporting

This is a problem that blocks releases every time:

https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/33593/files#diff-a130a63473f70bd378b211cd809cb20b6629b62ae603fd1b280445412a2dfa95R7
@codeboten codeboten added the needs triage New item requiring triage label Jun 17, 2024
@codeboten
Copy link
Contributor Author

A workaround is to run the command w/ the same go version as what's in the repo

@crobert-1 crobert-1 added ci-cd CI, CD, testing, build issues help wanted Extra attention is needed good first issue Good for newcomers and removed needs triage New item requiring triage labels Jun 17, 2024
This was referenced Jun 19, 2024
Closed
Closed
Closed
Closed
Closed
Closed
@github-actions GitHub Actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Aug 19, 2024
@mowies
Copy link
Member

mowies commented Sep 24, 2024

I may have found a way to somewhat fix this issue. You can run go get toolchain@none and that will remove the toolchain directive from a go.mod file. I'll set up a PR with some new make targets for this, but maybe that also needs to be changed in the multimod tool, not sure yet. I'll dig a bit more tomorrow.

@github-actions github-actions bot removed the Stale label Sep 25, 2024
@mowies mowies mentioned this issue Sep 30, 2024
Merged
@mowies
Copy link
Member

mowies commented Sep 30, 2024

@codeboten PR is open: #35490

@mx-psi mx-psi closed this as completed in 795694c Oct 1, 2024
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this issue Oct 4, 2024
@mowies @jriguera
[chore] add remove-toolchain make cmd (open-telemetry#35490)
e2547a5 
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

This PR adds a new `remove-toolchain` make command which removes the
`toolchain` directive from all go.mod files.
The new make command is also added to the `update-otel` make target.

**Link to tracking Issue:** <Issue number if applicable>
- fixes
open-telemetry#33600
- could potentially also work for
open-telemetry#35160

**Testing:** <Describe what testing was performed and which tests were
added.>
- add a `toolchain go1.22.5` directive to any of the go.mod files in
this repo
- call `make remove-toolchain`
- check if the toolchain directive was removed

---------

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci-cd CI, CD, testing, build issues good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[chore] add remove-toolchain make cmd dynatrace-oss-contrib/opentelemetry-collector-contrib
3 participants
@codeboten @mowies @crobert-1